You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by fg...@apache.org on 2021/05/25 15:23:55 UTC

[nifi-minifi-cpp] branch main updated: MINIFICPP-1563 fix -Wmaybe-uninitialized warnings

This is an automated email from the ASF dual-hosted git repository.

fgerlits pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/nifi-minifi-cpp.git


The following commit(s) were added to refs/heads/main by this push:
     new cde679f  MINIFICPP-1563 fix -Wmaybe-uninitialized warnings
cde679f is described below

commit cde679f71067afe087dbe8c0c6fa96a8aa80fd5e
Author: Marton Szasz <sz...@gmail.com>
AuthorDate: Wed May 19 15:48:30 2021 +0200

    MINIFICPP-1563 fix -Wmaybe-uninitialized warnings
    
    Signed-off-by: Ferenc Gerlits <fg...@gmail.com>
    
    This closes #1077
---
 extensions/librdkafka/tests/ConsumeKafkaTests.cpp | 4 ++--
 libminifi/include/c2/PayloadSerializer.h          | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/extensions/librdkafka/tests/ConsumeKafkaTests.cpp b/extensions/librdkafka/tests/ConsumeKafkaTests.cpp
index 0b06919..d37bef4 100644
--- a/extensions/librdkafka/tests/ConsumeKafkaTests.cpp
+++ b/extensions/librdkafka/tests/ConsumeKafkaTests.cpp
@@ -419,8 +419,8 @@ class ConsumeKafkaContinuousPublishingTest : public ConsumeKafkaTest {
     plan_->scheduleProcessors();
 
     const auto get_time_property_ms = [] (const std::string& property_string) {
-      int64_t value;
-      org::apache::nifi::minifi::core::TimeUnit unit;
+      int64_t value{};
+      org::apache::nifi::minifi::core::TimeUnit unit{};
       REQUIRE(org::apache::nifi::minifi::core::Property::StringToTime(property_string, value, unit));
       int64_t value_as_ms;
       REQUIRE(org::apache::nifi::minifi::core::Property::ConvertTimeUnitToMS(value, unit, value_as_ms));
diff --git a/libminifi/include/c2/PayloadSerializer.h b/libminifi/include/c2/PayloadSerializer.h
index a5197c3..14e8f9e 100644
--- a/libminifi/include/c2/PayloadSerializer.h
+++ b/libminifi/include/c2/PayloadSerializer.h
@@ -222,7 +222,7 @@ class PayloadSerializer {
   static bool deserializePayload(C2Payload &parent, Operation operation, std::string identifier, io::BaseStream *stream) {
     uint32_t payloads = 0;
     stream->read(payloads);
-    uint8_t op, st;
+    uint8_t op{}, st{};
     std::string label;
     for (size_t i = 0; i < payloads; i++) {
       stream->read(op);
@@ -257,7 +257,7 @@ class PayloadSerializer {
   static bool deserialize(std::vector<uint8_t> data, C2Payload &payload) {
     io::BufferStream stream(data.data(), gsl::narrow<unsigned int>(data.size()));
 
-    uint8_t op, st = 0;
+    uint8_t op = 0, st = 0;
     uint16_t version = 0;
 
     std::string identifier, label;