You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/25 08:35:00 UTC
[jira] [Commented] (KAFKA-6948) Avoid overflow in timestamp
comparison
[ https://issues.apache.org/jira/browse/KAFKA-6948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490417#comment-16490417 ]
ASF GitHub Bot commented on KAFKA-6948:
---------------------------------------
thisthat opened a new pull request #5078: KAFKA-6948 Change comparison to avoid overflow inconsistencies
URL: https://github.com/apache/kafka/pull/5078
Change timestamp comparison following what the Java documentation recommends to help preventing such errors.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Avoid overflow in timestamp comparison
> --------------------------------------
>
> Key: KAFKA-6948
> URL: https://issues.apache.org/jira/browse/KAFKA-6948
> Project: Kafka
> Issue Type: Improvement
> Reporter: Giovanni Liva
> Priority: Major
>
> Some comparisons with timestamp values are not safe. This comparisons can trigger errors that were found in some other issues, e.g. KAFKA-4290 or KAFKA-6608.
> The following classes contains some comparison between timestamps that can overflow.
> * org.apache.kafka.clients.NetworkClientUtils
> * org.apache.kafka.clients.consumer.internals.ConsumerCoordinator
> * org.apache.kafka.common.security.kerberos.KerberosLogin
> * org.apache.kafka.connect.runtime.WorkerSinkTask
> * org.apache.kafka.connect.tools.MockSinkTask
> * org.apache.kafka.connect.tools.MockSourceTask
> * org.apache.kafka.streams.processor.internals.GlobalStreamThread
> * org.apache.kafka.streams.processor.internals.StateDirectory
> * org.apache.kafka.streams.processor.internals.StreamThread
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)