You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2022/06/05 13:44:54 UTC

svn commit: r1901673 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDRadioButton.java

Author: tilman
Date: Sun Jun  5 13:44:54 2022
New Revision: 1901673

URL: http://svn.apache.org/viewvc?rev=1901673&view=rev
Log:
PDFBOX-4892: optimize / refactor, as suggested by Valery Bokov

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDRadioButton.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDRadioButton.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDRadioButton.java?rev=1901673&r1=1901672&r2=1901673&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDRadioButton.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDRadioButton.java Sun Jun  5 13:44:54 2022
@@ -18,7 +18,6 @@ package org.apache.pdfbox.pdmodel.intera
 
 import java.util.ArrayList;
 import java.util.List;
-import java.util.Set;
 
 import org.apache.pdfbox.cos.COSDictionary;
 import org.apache.pdfbox.cos.COSName;
@@ -122,7 +121,6 @@ public final class PDRadioButton extends
      */
     public List<String> getSelectedExportValues()
     {
-        Set<String> onValues = getOnValues();
         List<String> exportValues = getExportValues();
         List<String> selectedExportValues = new ArrayList<>();
         if (exportValues.isEmpty())
@@ -134,7 +132,7 @@ public final class PDRadioButton extends
         {
             String fieldValue = getValue();
             int idx = 0;
-            for (String onValue : onValues)
+            for (String onValue : getOnValues())
             {
                 if (onValue.compareTo(fieldValue) == 0)
                 {