You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2016/09/03 13:42:05 UTC
[GitHub] flink pull request #2469: [FLINK-4572] [gelly] Convert to negative in LongVa...
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2469
[FLINK-4572] [gelly] Convert to negative in LongValueToIntValue
The Gelly drivers expect that scale 32 edges, represented by the lower 32 bits of long values, can be converted to int values. Values between 2^31 and 2^32 - 1 should be converted to negative integers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 4572_convert_to_negative_in_longvaluetointvalue
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2469.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2469
----
commit 8a9fad5bb72e2f399b2afd0d095b6e29c9e5c9d0
Author: Greg Hogan <co...@greghogan.com>
Date: 2016-09-02T16:01:29Z
[FLINK-4572] [gelly] Convert to negative in LongValueToIntValue
The Gelly drivers expect that scale 32 edges, represented by the lower
32 bits of long values, can be converted to int values. Values between
2^31 and 2^32 - 1 should be converted to negative integers.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2469: [FLINK-4572] [gelly] Convert to negative in LongValueToIn...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2469
Do you have a second use case in mind for adding this function to `MathUtils`? My thought would be to keep this separate to avoid confusion between signed and unsigned downcasts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2469: [FLINK-4572] [gelly] Convert to negative in LongValueToIn...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2469
Looks good. Does it make sense to add to extend the `MathUtils.checkedDownCast(...)` function, or add a `MathUtils.checkedSignedDownCast(...)` function?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2469: [FLINK-4572] [gelly] Convert to negative in LongVa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2469
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2469: [FLINK-4572] [gelly] Convert to negative in LongValueToIn...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2469
I split the long to int translator into both signed and unsigned translators so the conversion would not be ambiguous. The test will fail without the fix in FLINK-4594.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---