You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/05/08 07:27:05 UTC

[GitHub] [ratis] szetszwo commented on a diff in pull request #640: RATIS-1570. Add getLeaderId method to DivisionInfo

szetszwo commented on code in PR #640:
URL: https://github.com/apache/ratis/pull/640#discussion_r867447715


##########
ratis-server-api/src/main/java/org/apache/ratis/server/DivisionInfo.java:
##########
@@ -20,6 +20,8 @@
 
 import org.apache.ratis.proto.RaftProtos.RaftPeerRole;
 import org.apache.ratis.proto.RaftProtos.RoleInfoProto;
+import org.apache.ratis.protocol.RaftPeer;

Review Comment:
   Please remove this.  There is a checkstyle warning: https://github.com/apache/ratis/runs/6335329880?check_suite_focus=true#step:4:262 .



##########
ratis-server-api/src/main/java/org/apache/ratis/server/DivisionInfo.java:
##########
@@ -51,6 +53,12 @@ default boolean isListener() {
   /** Is this server division currently the leader and ready? */
   boolean isLeaderReady();
 
+  /**
+   * @return return the id of the current leader if the leader is known to this server division;

Review Comment:
   The second "return" should be removed; see https://www.oracle.com/hk/technical-resources/articles/java/javadoc-tool.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org