[jira] [Commented] (BEAM-1656) DirectRunner should not call finalize twice in UnboundedSourceExecutorFactory

["Thomas Groh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901835#comment-15901835 ] 

Thomas Groh commented on BEAM-1656:
-----------------------------------

Removing the call to {{finalizeCheckpoint}} in {{getReader}} should be sufficient. All checkpoints will still be finalized, either after taking the next checkpoint or after no more checkpoints will be taken.

> DirectRunner should not call finalize twice in UnboundedSourceExecutorFactory
> -----------------------------------------------------------------------------
>
>                 Key: BEAM-1656
>                 URL: https://issues.apache.org/jira/browse/BEAM-1656
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-direct
>            Reporter: Ben Chambers
>            Assignee: Thomas Groh
>
> In [getReader](https://github.com/apache/beam/blob/master/runners/direct-java/src/main/java/org/apache/beam/runners/direct/UnboundedReadEvaluatorFactory.java#L174) we call finalize on the checkpoint that arrived in the incoming shard. Then later in [finishRead](https://github.com/apache/beam/blob/master/runners/direct-java/src/main/java/org/apache/beam/runners/direct/UnboundedReadEvaluatorFactory.java#L205) we finalize the old checkpoint again.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)