You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/02/07 15:21:29 UTC
[GitHub] [incubator-mxnet] agrabows commented on a change in pull request #20835: [FEATURE] Add quantized version of reshape with DNNL reorder primitive.
agrabows commented on a change in pull request #20835:
URL: https://github.com/apache/incubator-mxnet/pull/20835#discussion_r800765469
##########
File path: src/operator/quantization/quantized_reshape.cc
##########
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file quantized_reshape.cc
+ * \author: Adam Grabowski, adam.grabowski@intel.com
+ */
+
+#include <utility>
+#include "quantized_reshape-inl.h"
+
+namespace mxnet {
+namespace op {
+
+void QuantizedReshapeCompute(const nnvm::NodeAttrs& attrs,
+ const OpContext& ctx,
+ const std::vector<TBlob>& inputs,
+ const std::vector<OpReqType>& req,
+ const std::vector<TBlob>& outputs) {
+ CHECK_EQ(inputs.size(), 3U);
+ CHECK_EQ(outputs.size(), 3U);
+ CHECK_EQ(req.size(), 3U);
+
+ if (req[0] != kWriteInplace)
+ UnaryOp::IdentityCompute<cpu>(attrs, ctx, inputs, req, outputs);
+
+ *outputs[1].dptr<float>() = *inputs[1].dptr<float>();
+ *outputs[2].dptr<float>() = *inputs[2].dptr<float>();
+}
+
+#define MXNET_OPERATOR_REGISTER_QUANTIZED_RESHAPE(name) \
+ NNVM_REGISTER_OP(name) \
+ .set_num_inputs(3) \
+ .set_num_outputs(3) \
+ .set_attr<nnvm::FListInputNames>( \
+ "FListInputNames", \
+ [](const NodeAttrs& attrs) { \
+ return std::vector<std::string>{"data", "min_data", "max_data"}; \
+ }) \
+ .set_attr<nnvm::FListOutputNames>( \
+ "FListOutputNames", \
+ [](const NodeAttrs& attrs) { \
+ return std::vector<std::string>{"output", "min_output", "max_output"}; \
+ }) \
+ .set_attr<nnvm::FInplaceOption>( \
+ "FInplaceOption", \
+ [](const NodeAttrs& attrs) { \
+ return std::vector<std::pair<int, int> >{{0, 0}, {1, 1}, {2, 2}}; \
+ }) \
+ .set_attr<FCompute>("FCompute<cpu>", QuantizedReshapeCompute) \
+ .set_attr<FResourceRequest>( \
+ "FResourceRequest", \
+ [](const NodeAttrs& n) { \
+ return std::vector<ResourceRequest>{ResourceRequest::kTempSpace}; \
+ }) \
+ .set_attr<nnvm::FInferType>("FInferType", QuantizedReshapeType) \
+ .set_attr<nnvm::FGradient>("FGradient", MakeZeroGradNodes) \
+ .set_attr<FQuantizable>("FQuantizable", \
+ [](const NodeAttrs& attrs) { return QuantizeType::kSupport; }) \
+ .add_argument("data", "NDArray-or-Symbol", "Array to be reshaped.") \
+ .add_argument("min_data", \
+ "NDArray-or-Symbol", \
+ "The minimum scalar value " \
+ "possibly produced for the data") \
+ .add_argument("max_data", \
+ "NDArray-or-Symbol", \
+ "The maximum scalar value " \
+ "possibly produced for the data")
+
+MXNET_OPERATOR_REGISTER_QUANTIZED_RESHAPE(_contrib_quantized_reshape)
+ .add_alias("quantized_reshape")
+ .set_attr_parser(ParamParser<ReshapeParam>)
+ .set_attr<mxnet::FInferShape>("FInferShape", QuantizedReshapeInferShape<ReshapeShape>)
+ .add_arguments(ReshapeParam::__FIELDS__());
+
+MXNET_OPERATOR_REGISTER_QUANTIZED_RESHAPE(_npx_quantized_reshape)
+ .set_attr_parser(ParamParser<NumpyXReshapeParam>)
+ .set_attr<mxnet::FInferShape>("FInferShape", QuantizedReshapeInferShape<NumpyXReshapeShape>)
+ .add_arguments(NumpyXReshapeParam::__FIELDS__());
+
+template <bool is_numpy_op>
+nnvm::ObjectPtr QuantizedReshapeNode(const NodeAttrs& attrs) {
+ nnvm::ObjectPtr node = nnvm::Node::Create();
+
+ if constexpr (is_numpy_op) {
+ node->attrs.op = Op::Get("_npx_quantized_reshape");
+ } else {
+ node->attrs.op = Op::Get("_contrib_quantized_reshape");
+ }
Review comment:
We could do it using global strings however global variables are not advisable. Instead, after consulting with @bgawrych and @mozga-intel, enumerate version of this functionality was created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org