You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2020/08/04 16:28:24 UTC

[GitHub] [avro] cewing commented on pull request #936: AVRO-2906: Traversal validation

cewing commented on pull request #936:
URL: https://github.com/apache/avro/pull/936#issuecomment-668696661


   @kojiromike so all the tests pass now (thanks to @RyanSkraba!).  It's unclear to me what the next steps are.  The contributing docs in the avro wiki appear to suggest that one can *either* open a PR here or submit a patch via Jira.  Should I create a patch and submit it via Jira?  
   
   In addition, one of the claims of this PR is that it will be more memory efficient because of moving away from recursive processing.  Do I need to add a test for a more deeply nested schema that demonstrates this savings? Should I do some performance analysis that shows that this approach hasn't slowed down the parsing process for large schemas?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org