You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/22 09:25:47 UTC
[GitHub] [kafka] dengziming opened a new pull request #9638: MINOR; Remove duplicate update updateLeaderEndOffsetAndTimestamp
dengziming opened a new pull request #9638:
URL: https://github.com/apache/kafka/pull/9638
The `KafkaRaftClient.onBecomeLeader` will invoke `appendLeaderChangeMessage`, the call stack are:
```
1. appendLeaderChangeMessage
1.1 flushLeaderLog
1.1.1 updateLeaderEndOffsetAndTimestamp
1.1.2 log.flush()
```
so the `updateLeoAndTs ` is already invoked, and `updateLeoAndTs` should only be invoked after leo change(or time change), since `log.flush()` will not change leo(and ts), it's unnessary to invoke twice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming closed pull request #9638: MINOR; Remove duplicate updateLeaderEndOffsetAndTimestamp
Posted by GitBox <gi...@apache.org>.
dengziming closed pull request #9638:
URL: https://github.com/apache/kafka/pull/9638
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on pull request #9638: MINOR; Remove duplicate update updateLeaderEndOffsetAndTimestamp
Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #9638:
URL: https://github.com/apache/kafka/pull/9638#issuecomment-731720762
ping @hachikuji to have a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org