You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by an...@apache.org on 2018/07/24 20:17:01 UTC
[2/8] mesos git commit: Windows: Documented why the `RemoteLinkLeak`
test is not enabled.
Windows: Documented why the `RemoteLinkLeak` test is not enabled.
Review: https://reviews.apache.org/r/67979
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/ac3b74e9
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/ac3b74e9
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/ac3b74e9
Branch: refs/heads/master
Commit: ac3b74e9f29c2bdd5feb9d679f15405643d61edb
Parents: 81e4944
Author: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Authored: Wed Jul 18 17:11:49 2018 -0700
Committer: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Committed: Tue Jul 24 10:58:52 2018 -0700
----------------------------------------------------------------------
3rdparty/libprocess/src/tests/process_tests.cpp | 6 ++++++
1 file changed, 6 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/ac3b74e9/3rdparty/libprocess/src/tests/process_tests.cpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/src/tests/process_tests.cpp b/3rdparty/libprocess/src/tests/process_tests.cpp
index d124b5a..d5d9afc 100644
--- a/3rdparty/libprocess/src/tests/process_tests.cpp
+++ b/3rdparty/libprocess/src/tests/process_tests.cpp
@@ -998,6 +998,12 @@ TEST_F(ProcessRemoteLinkTest, RemoteDoubleLinkRelink)
// Verifies that remote links will trigger an `ExitedEvent` if the link
// fails during socket creation. The test instigates a socket creation
// failure by hogging all available file descriptors.
+//
+// TODO(andschwa): Enable this test. The current logic will not work on Windows
+// as " The Microsoft Winsock provider limits the maximum number of sockets
+// supported only by available memory on the local computer." See MESOS-9093.
+//
+// https://docs.microsoft.com/en-us/windows/desktop/WinSock/maximum-number-of-sockets-supported-2 // NOLINT(whitespace/line_length)
TEST_F_TEMP_DISABLED_ON_WINDOWS(ProcessRemoteLinkTest, RemoteLinkLeak)
{
RemoteLinkTestProcess relinker(pid);