You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/26 22:18:49 UTC

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request, #7440: libs/libc/time: mktime normalize struct tm

pkarashchenko opened a new pull request, #7440:
URL: https://github.com/apache/incubator-nuttx/pull/7440

   ## Summary
   
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] fjpanag commented on pull request #7440: libs/libc/time: mktime normalize struct tm

Posted by GitBox <gi...@apache.org>.
fjpanag commented on PR #7440:
URL: https://github.com/apache/incubator-nuttx/pull/7440#issuecomment-1293778145

   @pkarashchenko This commit made our internal tests fail.
   
   Specifically, I am running the Lua v5.2 test suite and it gives me the following message:
   
   ```
   /mnt/sdcard0/files.lua:572: assertion failed!
   ```
   
   This is the offending line:
   
   ```
   local t = os.time()
   D = os.date("*t", t)
   
   assert(os.time(D) == t)  -- This line here fails!
   ```
   
   I can track this down, and get the actual NuttX issue hidden behind the Lua libraries, but unfortunately due to a national holiday, this will have to wait till Monday.
   
   Unless you can troubleshoot this sooner...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7440: libs/libc/time: mktime normalize struct tm

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7440:
URL: https://github.com/apache/incubator-nuttx/pull/7440


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7440: libs/libc/time: mktime normalize struct tm

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #7440:
URL: https://github.com/apache/incubator-nuttx/pull/7440#issuecomment-1294042561

   @fjpanag I found the root cause. It is fixed in https://github.com/apache/incubator-nuttx/pull/7455


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7440: libs/libc/time: mktime normalize struct tm

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #7440:
URL: https://github.com/apache/incubator-nuttx/pull/7440#issuecomment-1293864550

   Ok. Let me take a look tomorrow. If I will not be able to narrow down the issue, then we will revert the change until I find a riot cause


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org