You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/10/01 04:00:57 UTC
[kudu-CR] table locations-itest: restrict benchmark to slow mode
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14328
to review the following change.
Change subject: table_locations-itest: restrict benchmark to slow mode
......................................................................
table_locations-itest: restrict benchmark to slow mode
The CreateTable RPC can time out in TSAN mode, and perhaps in ASAN as well.
So let's just restrict it to slow mode, which is what we usually do in tests
that create a replicated table with many tablets.
Change-Id: I867b629be2f51838c453b078b5617042fc8468aa
---
M src/kudu/integration-tests/table_locations-itest.cc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/14328/1
--
To view, visit http://gerrit.cloudera.org:8080/14328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I867b629be2f51838c453b078b5617042fc8468aa
Gerrit-Change-Number: 14328
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] table locations-itest: restrict benchmark to slow mode
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/14328 )
Change subject: table_locations-itest: restrict benchmark to slow mode
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I867b629be2f51838c453b078b5617042fc8468aa
Gerrit-Change-Number: 14328
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] table locations-itest: restrict benchmark to slow mode
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14328 )
Change subject: table_locations-itest: restrict benchmark to slow mode
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I867b629be2f51838c453b078b5617042fc8468aa
Gerrit-Change-Number: 14328
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Oct 2019 05:03:44 +0000
Gerrit-HasComments: No
[kudu-CR] table locations-itest: restrict benchmark to slow mode
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14328 )
Change subject: table_locations-itest: restrict benchmark to slow mode
......................................................................
Patch Set 1: Verified+1
Overriding Jenkins, unrelated test failure.
--
To view, visit http://gerrit.cloudera.org:8080/14328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I867b629be2f51838c453b078b5617042fc8468aa
Gerrit-Change-Number: 14328
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Oct 2019 06:05:03 +0000
Gerrit-HasComments: No
[kudu-CR] table locations-itest: restrict benchmark to slow mode
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14328 )
Change subject: table_locations-itest: restrict benchmark to slow mode
......................................................................
table_locations-itest: restrict benchmark to slow mode
The CreateTable RPC can time out in TSAN mode, and perhaps in ASAN as well.
So let's just restrict it to slow mode, which is what we usually do in tests
that create a replicated table with many tablets.
Change-Id: I867b629be2f51838c453b078b5617042fc8468aa
Reviewed-on: http://gerrit.cloudera.org:8080/14328
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/integration-tests/table_locations-itest.cc
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
Adar Dembo: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I867b629be2f51838c453b078b5617042fc8468aa
Gerrit-Change-Number: 14328
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] table locations-itest: restrict benchmark to slow mode
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14328 )
Change subject: table_locations-itest: restrict benchmark to slow mode
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I867b629be2f51838c453b078b5617042fc8468aa
Gerrit-Change-Number: 14328
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Oct 2019 04:14:02 +0000
Gerrit-HasComments: No