You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Chris Chabot (JIRA)" <ji...@apache.org> on 2008/07/10 14:10:33 UTC
[jira] Resolved: (SHINDIG-439) Missing type hinting regarding
SecurityToken in abstract PeopleService and UserId classes
[ https://issues.apache.org/jira/browse/SHINDIG-439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Chabot resolved SHINDIG-439.
----------------------------------
Resolution: Fixed
Assignee: Chris Chabot
Looks good, the other services had the type hinting too, so this was indeed an erroneous situation.
Applied & Committed, thanks!
> Missing type hinting regarding SecurityToken in abstract PeopleService and UserId classes
> -----------------------------------------------------------------------------------------
>
> Key: SHINDIG-439
> URL: https://issues.apache.org/jira/browse/SHINDIG-439
> Project: Shindig
> Issue Type: Bug
> Components: RESTful API (PHP)
> Reporter: Karsten Beyer
> Assignee: Chris Chabot
> Attachments: fix-issue-SHINDIG-439.patch
>
>
> The ActivitiesService and AppDataService both require the $token to be of type SecurityToken. For consistency this should also be the case for the PeopleService abstract class and the UserId handler class as both of them indeed require the $token parameter to be of type SecurityToken.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Resolved: (SHINDIG-439) Missing type hinting regarding SecurityToken in abstract PeopleService and UserId classes
Posted by Chris Chabot <ch...@xs4all.nl>.
Agreed, as the saying goes "patches are welcome" :-)
-- Chris
On Jul 10, 2008, at 2:21 PM, Ropu wrote:
> Hi
>
> i think we should add Type Hinting as a *Good Practice *for all PHP
> Code now
> onwards, and start adding that to actual code.
>
> Ropu
>
> On Thu, Jul 10, 2008 at 9:10 AM, Chris Chabot (JIRA) <ji...@apache.org>
> wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/SHINDIG-439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Chris Chabot resolved SHINDIG-439.
>> ----------------------------------
>>
>> Resolution: Fixed
>> Assignee: Chris Chabot
>>
>> Looks good, the other services had the type hinting too, so this
>> was indeed
>> an erroneous situation.
>>
>> Applied & Committed, thanks!
>>
>>> Missing type hinting regarding SecurityToken in abstract
>>> PeopleService
>> and UserId classes
>>>
>> -----------------------------------------------------------------------------------------
>>>
>>> Key: SHINDIG-439
>>> URL: https://issues.apache.org/jira/browse/
>>> SHINDIG-439
>>> Project: Shindig
>>> Issue Type: Bug
>>> Components: RESTful API (PHP)
>>> Reporter: Karsten Beyer
>>> Assignee: Chris Chabot
>>> Attachments: fix-issue-SHINDIG-439.patch
>>>
>>>
>>> The ActivitiesService and AppDataService both require the $token
>>> to be of
>> type SecurityToken. For consistency this should also be the case
>> for the
>> PeopleService abstract class and the UserId handler class as both
>> of them
>> indeed require the $token parameter to be of type SecurityToken.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
>
> --
> .-. --- .--. ..-
> R o p u
Re: [jira] Resolved: (SHINDIG-439) Missing type hinting regarding SecurityToken in abstract PeopleService and UserId classes
Posted by Ropu <ro...@gmail.com>.
Hi
i think we should add Type Hinting as a *Good Practice *for all PHP Code now
onwards, and start adding that to actual code.
Ropu
On Thu, Jul 10, 2008 at 9:10 AM, Chris Chabot (JIRA) <ji...@apache.org>
wrote:
>
> [
> https://issues.apache.org/jira/browse/SHINDIG-439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Chris Chabot resolved SHINDIG-439.
> ----------------------------------
>
> Resolution: Fixed
> Assignee: Chris Chabot
>
> Looks good, the other services had the type hinting too, so this was indeed
> an erroneous situation.
>
> Applied & Committed, thanks!
>
> > Missing type hinting regarding SecurityToken in abstract PeopleService
> and UserId classes
> >
> -----------------------------------------------------------------------------------------
> >
> > Key: SHINDIG-439
> > URL: https://issues.apache.org/jira/browse/SHINDIG-439
> > Project: Shindig
> > Issue Type: Bug
> > Components: RESTful API (PHP)
> > Reporter: Karsten Beyer
> > Assignee: Chris Chabot
> > Attachments: fix-issue-SHINDIG-439.patch
> >
> >
> > The ActivitiesService and AppDataService both require the $token to be of
> type SecurityToken. For consistency this should also be the case for the
> PeopleService abstract class and the UserId handler class as both of them
> indeed require the $token parameter to be of type SecurityToken.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
--
.-. --- .--. ..-
R o p u