You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Chad Walters (JIRA)" <ji...@apache.org> on 2009/04/08 09:37:13 UTC
[jira] Commented: (THRIFT-414) Support non-UTF-8 in Java and C#
[ https://issues.apache.org/jira/browse/THRIFT-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696926#action_12696926 ]
Chad Walters commented on THRIFT-414:
-------------------------------------
+1 on the Java patch
Your comments on the JSON protocol raise an issue that should be addressed. I'll open a separate ticket for that problem.
> Support non-UTF-8 in Java and C#
> --------------------------------
>
> Key: THRIFT-414
> URL: https://issues.apache.org/jira/browse/THRIFT-414
> Project: Thrift
> Issue Type: New Feature
> Components: Compiler (C#), Compiler (Cocoa), Compiler (Java), Library (C#), Library (Cocoa), Library (Java)
> Reporter: David Reiss
> Attachments: 0001-THRIFT-414.-Non-UTF-8-string-support-for-Java.patch
>
>
> Java and C# Thrift assume that all strings should be UTF-8. A better approach would be:
> - Give the readString and writeString protocol methods an encoding parameter, probably defaulting to UTF-8 for compatibility and convenience.
> - Make generated struct readers and writers pass the argument to the protocol objects for each string.
> - Allow a type annotation to override the default UTF-8 encoding.
> - All other languages (except Python 3) should ignore the annotation, but it will serve as documentation for the application.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.