You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/24 20:55:56 UTC

[GitHub] [arrow] rok opened a new pull request #12511: ARROW-15748: [Python] Round temporal options default unit is `day` but documented as `second`. Follow-up

rok opened a new pull request #12511:
URL: https://github.com/apache/arrow/pull/12511


   This is a follow-up to https://github.com/apache/arrow/pull/12507 to address @jorisvandenbossche's [comment](https://github.com/apache/arrow/pull/12507#pullrequestreview-892910661).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12511: ARROW-15748: [Python] Round temporal options default unit is `day` but documented as `second`. Follow-up

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12511:
URL: https://github.com/apache/arrow/pull/12511#issuecomment-1068056006


   Benchmark runs are scheduled for baseline = b203c668834ea928c5929569a90fc0937284011f and contender = fbbe5361eff3c1601b7b5f228c52a662f4c124e4. fbbe5361eff3c1601b7b5f228c52a662f4c124e4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/dc9b4c977f1a4ba9a3eba68449a98bc1...e91c151c6e0c444e918bff413044271e/)
   [Finished :arrow_down:0.29% :arrow_up:0.13%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/97ef810a4e01494b88fc04b8189d5b84...a64b046118794a98af2981ea395b4ad2/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/fbaf363c8244437083d46cae0ea487d5...ee72dd7929dd4f8ab9212f99fd58aaa2/)
   [Finished :arrow_down:0.21% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/bc39f42f2273434096941e3c01e58bfe...83519cfc616a441b9d14a585ffeb447b/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12511: ARROW-15748: [Python] Round temporal options default unit is `day` but documented as `second`. Follow-up

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12511:
URL: https://github.com/apache/arrow/pull/12511#issuecomment-1068056006


   Benchmark runs are scheduled for baseline = b203c668834ea928c5929569a90fc0937284011f and contender = fbbe5361eff3c1601b7b5f228c52a662f4c124e4. fbbe5361eff3c1601b7b5f228c52a662f4c124e4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/dc9b4c977f1a4ba9a3eba68449a98bc1...e91c151c6e0c444e918bff413044271e/)
   [Finished :arrow_down:0.29% :arrow_up:0.13%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/97ef810a4e01494b88fc04b8189d5b84...a64b046118794a98af2981ea395b4ad2/)
   [Finished :arrow_down:1.07% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/fbaf363c8244437083d46cae0ea487d5...ee72dd7929dd4f8ab9212f99fd58aaa2/)
   [Finished :arrow_down:0.21% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/bc39f42f2273434096941e3c01e58bfe...83519cfc616a441b9d14a585ffeb447b/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12511: ARROW-15748: [Python] Round temporal options default unit is `day` but documented as `second`. Follow-up

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12511:
URL: https://github.com/apache/arrow/pull/12511#issuecomment-1068056006


   Benchmark runs are scheduled for baseline = b203c668834ea928c5929569a90fc0937284011f and contender = fbbe5361eff3c1601b7b5f228c52a662f4c124e4. fbbe5361eff3c1601b7b5f228c52a662f4c124e4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/dc9b4c977f1a4ba9a3eba68449a98bc1...e91c151c6e0c444e918bff413044271e/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/97ef810a4e01494b88fc04b8189d5b84...a64b046118794a98af2981ea395b4ad2/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/fbaf363c8244437083d46cae0ea487d5...ee72dd7929dd4f8ab9212f99fd58aaa2/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/bc39f42f2273434096941e3c01e58bfe...83519cfc616a441b9d14a585ffeb447b/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] rok commented on pull request #12511: ARROW-15748: [Python] Round temporal options default unit is `day` but documented as `second`. Follow-up

Posted by GitBox <gi...@apache.org>.
rok commented on pull request #12511:
URL: https://github.com/apache/arrow/pull/12511#issuecomment-1050908278


   @pitrou sorry this is a bit of a test spam but @jorisvandenbossche is right about temporal options not being tested in master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12511: ARROW-15748: [Python] Round temporal options default unit is `day` but documented as `second`. Follow-up

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12511:
URL: https://github.com/apache/arrow/pull/12511#issuecomment-1068056006


   Benchmark runs are scheduled for baseline = b203c668834ea928c5929569a90fc0937284011f and contender = fbbe5361eff3c1601b7b5f228c52a662f4c124e4. fbbe5361eff3c1601b7b5f228c52a662f4c124e4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/dc9b4c977f1a4ba9a3eba68449a98bc1...e91c151c6e0c444e918bff413044271e/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/97ef810a4e01494b88fc04b8189d5b84...a64b046118794a98af2981ea395b4ad2/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/fbaf363c8244437083d46cae0ea487d5...ee72dd7929dd4f8ab9212f99fd58aaa2/)
   [Finished :arrow_down:0.21% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/bc39f42f2273434096941e3c01e58bfe...83519cfc616a441b9d14a585ffeb447b/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #12511: ARROW-15748: [Python] Round temporal options default unit is `day` but documented as `second`. Follow-up

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12511:
URL: https://github.com/apache/arrow/pull/12511#issuecomment-1050256162


   https://issues.apache.org/jira/browse/ARROW-15748


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jorisvandenbossche closed pull request #12511: ARROW-15748: [Python] Round temporal options default unit is `day` but documented as `second`. Follow-up

Posted by GitBox <gi...@apache.org>.
jorisvandenbossche closed pull request #12511:
URL: https://github.com/apache/arrow/pull/12511


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot commented on pull request #12511: ARROW-15748: [Python] Round temporal options default unit is `day` but documented as `second`. Follow-up

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12511:
URL: https://github.com/apache/arrow/pull/12511#issuecomment-1068056006


   Benchmark runs are scheduled for baseline = b203c668834ea928c5929569a90fc0937284011f and contender = fbbe5361eff3c1601b7b5f228c52a662f4c124e4. fbbe5361eff3c1601b7b5f228c52a662f4c124e4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/dc9b4c977f1a4ba9a3eba68449a98bc1...e91c151c6e0c444e918bff413044271e/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/97ef810a4e01494b88fc04b8189d5b84...a64b046118794a98af2981ea395b4ad2/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/fbaf363c8244437083d46cae0ea487d5...ee72dd7929dd4f8ab9212f99fd58aaa2/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/bc39f42f2273434096941e3c01e58bfe...83519cfc616a441b9d14a585ffeb447b/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org