[GitHub] [apisix-dashboard] Baoyuantop commented on a change in pull request #2359: feat: Modify plugin preview page

[GitBox <gi...@apache.org>]

Baoyuantop commented on a change in pull request #2359:
URL: https://github.com/apache/apisix-dashboard/pull/2359#discussion_r825536650



##########
File path: web/src/components/Plugin/PluginPage.tsx
##########
@@ -92,6 +92,13 @@ const PluginPage: React.FC<Props> = ({
       form.setFieldsValue({ plugin_config_id });
     });
   }, []);
+  const openPlugin = pluginList.filter(
+    (item) => initialData[item.name] && !initialData[item.name].disable,
+  );
+  const openPluginType = openPlugin.map((item) => item.type);
+  const newOpenPluginType = openPluginType.filter((elem, index, self) => {
+    return index === self.indexOf(elem);
+  });

Review comment:
       Can you explain it? I'm a little confused.

##########
File path: web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js
##########
@@ -74,6 +75,8 @@ context('Create Configure and Delete PluginTemplate', () => {
 
     cy.contains('Submit').click();
     cy.contains('Next').click();
+    cy.contains(selector.pluginCard, 'basic-auth').should('be.visible');
+    cy.contains(selector.pluginTitle, 'Authentication').should('be.visible');

Review comment:
       not exist or not visible?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org