[GitHub] [druid] somu-imply commented on a diff in pull request #14007: Fixing NPE in window functions when order by DESC is used within OVER

["somu-imply (via GitHub)" <gi...@apache.org>]

somu-imply commented on code in PR #14007:
URL: https://github.com/apache/druid/pull/14007#discussion_r1154796168


##########
sql/src/test/resources/calcite/tests/window/wikipediaAggregationsMultipleOrderingDesc.sqlTest:
##########
@@ -10,16 +10,22 @@ sql: |
     FROM wikipedia
     GROUP BY 1, 2
     ORDER BY 1 DESC, 2 DESC
+    LIMIT 2
 
 expectedOperators:
+  - {type: "naiveSort", columns: [{column: "d0", direction: "ASC"}, {column: "d1", direction: "DESC"}]}
   - { type: "naivePartition",  partitionColumns: [ "d0" ] }
   - type: "window"
     processor:
       type: "framedAgg"
       frame: { peerType: "ROWS", lowUnbounded: false, lowOffset: 3, uppUnbounded: false, uppOffset: 2 }
       aggregations:
         - { type: "longSum", name: "w0", fieldName: "a0" }
-  - { type: "naiveSort", columns: [ { column: "d1", direction: "DESC" }, { column: "a0", direction: "DESC"} ]}

Review Comment:
   Unclear as in why this changed from ASC to DESC. Investigating further



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org