You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by grkvlt <gi...@git.apache.org> on 2016/09/06 23:58:26 UTC
[GitHub] brooklyn-server pull request #321: Added configuration for template substitu...
GitHub user grkvlt opened a pull request:
https://github.com/apache/brooklyn-server/pull/321
Added configuration for template substitution variable map
Adds a new `ConfigKey<Map<?,?>>` to allow setting further template variable substitutions in YAML.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/grkvlt/brooklyn-server add-template-substitutions-config
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/321.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #321
----
commit 064f578d7b379e1e367a16b4fef9893d588a71e0
Author: Andrew Donald Kennedy <an...@cloudsoftcorp.com>
Date: 2016-09-06T23:53:00Z
Added configuration for template substitution variable map
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #321: Added configuration for template substitu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/321
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #321: Added configuration for template substitution va...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the issue:
https://github.com/apache/brooklyn-server/pull/321
Yes, I used it like `${config['template.substitutions]['key1']}` which is equivalent, I think.
But if you add in the map explicitly, then you could just say `${key1}` in the template file, which is _much_ neater.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #321: Added configuration for template substitution va...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/321
I believe we can already do that with the existing functionality? Something like:
```
services:
- type: SoftwareProcess
brooklyn.config:
template.substitutions:
key1: value1
key2: value2
```
```
key1: ${config['template.substitutions.key1']}
key2: ${config['template.substitutions.key2']}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #321: Added configuration for template substitution va...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/321
Would be nice to have test coverage for this, but could be added in a future PR. Tests passing locally, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---