You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2014/09/11 23:58:37 UTC
Review Request 25562: SQOOP-1488: Sqoop2: From/To: Run both destroyers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25562/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1488
https://issues.apache.org/jira/browse/SQOOP-1488
Repository: sqoop-SQOOP-1367
Description
-------
Run FROM and TO destroyers.
Diffs
-----
execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java b05954b
execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 4cdb002
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 59431f4
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java bbf7342
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java b3461bb
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 2dfc487
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java cb782c7
Diff: https://reviews.apache.org/r/25562/diff/
Testing
-------
Ran all tests and integration tests.
Thanks,
Abraham Elmahrek
Re: Review Request 25562: SQOOP-1488: Sqoop2: From/To: Run both
destroyers
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25562/#review54091
-----------------------------------------------------------
The patch no longer applies on top of SQOOP-1367 branch, could you rebase it Abe?
- Jarek Cecho
On Sept. 11, 2014, 9:58 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25562/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 9:58 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1488
> https://issues.apache.org/jira/browse/SQOOP-1488
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> Run FROM and TO destroyers.
>
>
> Diffs
> -----
>
> execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java b05954b
> execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 4cdb002
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 59431f4
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java bbf7342
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java b3461bb
> execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 2dfc487
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java cb782c7
>
> Diff: https://reviews.apache.org/r/25562/diff/
>
>
> Testing
> -------
>
> Ran all tests and integration tests.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 25562: SQOOP-1488: Sqoop2: From/To: Run both
destroyers
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25562/#review54099
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Sept. 21, 2014, 6:16 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25562/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2014, 6:16 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1488
> https://issues.apache.org/jira/browse/SQOOP-1488
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> Run FROM and TO destroyers.
>
>
> Diffs
> -----
>
> execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java ef7ff4e
> execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 4cdb002
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java e3af6e1
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java 3e2b1c5
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java b3461bb
> execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 2dfc487
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java cb782c7
>
> Diff: https://reviews.apache.org/r/25562/diff/
>
>
> Testing
> -------
>
> Ran all tests and integration tests.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 25562: SQOOP-1488: Sqoop2: From/To: Run both
destroyers
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25562/
-----------------------------------------------------------
(Updated Sept. 21, 2014, 6:16 p.m.)
Review request for Sqoop.
Bugs: SQOOP-1488
https://issues.apache.org/jira/browse/SQOOP-1488
Repository: sqoop-SQOOP-1367
Description
-------
Run FROM and TO destroyers.
Diffs (updated)
-----
execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java ef7ff4e
execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 4cdb002
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java e3af6e1
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java 3e2b1c5
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java b3461bb
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 2dfc487
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java cb782c7
Diff: https://reviews.apache.org/r/25562/diff/
Testing
-------
Ran all tests and integration tests.
Thanks,
Abraham Elmahrek
Re: Review Request 25562: SQOOP-1488: Sqoop2: From/To: Run both
destroyers
Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25562/#review53730
-----------------------------------------------------------
Ship it!
Ship It!
- Gwen Shapira
On Sept. 11, 2014, 9:58 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25562/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 9:58 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1488
> https://issues.apache.org/jira/browse/SQOOP-1488
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> Run FROM and TO destroyers.
>
>
> Diffs
> -----
>
> execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java b05954b
> execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 4cdb002
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 59431f4
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java bbf7342
> execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java b3461bb
> execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java 2dfc487
> test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java cb782c7
>
> Diff: https://reviews.apache.org/r/25562/diff/
>
>
> Testing
> -------
>
> Ran all tests and integration tests.
>
>
> Thanks,
>
> Abraham Elmahrek
>
>