You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/12 03:05:35 UTC
[GitHub] [flink-kubernetes-operator] Aitozi opened a new pull request, #266: [FLINK-27960] Make the apt-get updating optional
Aitozi opened a new pull request, #266:
URL: https://github.com/apache/flink-kubernetes-operator/pull/266
when developing, we could use to speed up
```
docker build --build-arg FAST=true . -t <repo>/flink-kubernetes-operator:latest
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] Aitozi commented on pull request #266: [FLINK-27960] Make the apt-get updating optional
Posted by GitBox <gi...@apache.org>.
Aitozi commented on PR #266:
URL: https://github.com/apache/flink-kubernetes-operator/pull/266#issuecomment-1153856303
@mbalassi Thanks for reviewing
> I like the fast flag potentially controlling both
But the `SKIP_TESTS` and `FAST` have different default value. The `FAST` should be true to trigger update when building the artifact image (for the security reason https://issues.apache.org/jira/browse/FLINK-27728). So the default value need to be true, Right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #266: [FLINK-27960] Make the apt-get updating optional
Posted by GitBox <gi...@apache.org>.
mbalassi commented on PR #266:
URL: https://github.com/apache/flink-kubernetes-operator/pull/266#issuecomment-1153879405
@Aitozi apologies if I was unclear, for the sake of clarity of explanation let us introduce the `SKIP_OS_UPDATE` flag (you can choose to call this `FAST` or name the "shared" control flag `FAST` if you think having that makes sense).
1. By default / for dev builds:
```
SKIP_TESTS: true
SKIP_OS_UPDATE: true
```
So that if you choose to use `FAST` to control both it can be set to `true` by default.
2. For the CI / automated builds:
```
SKIP_TESTS: false
SKIP_OS_UPDATE: false
```
So that if you choose to use `FAST` to control both then the CI could set this flag to `false`.
If you choose to not introduce a shared flag, then I slightly prefer calling the flag you introduce here `SKIP_OS_UPDATE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #266: [FLINK-27960] Make the apt-get updating optional
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #266:
URL: https://github.com/apache/flink-kubernetes-operator/pull/266#issuecomment-1155014145
LGTM, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #266: [FLINK-27960] Make the apt-get updating optional
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #266:
URL: https://github.com/apache/flink-kubernetes-operator/pull/266#issuecomment-1154978874
> Hi @morhidi do you mean I do not need to add the in `.github/workflows/docker-bake.hcl` ?
>
> ```
> args = {
> SKIP_OS_UPDATE = false
> }
> ```
>
> Is this file will be used to build the release artifacts? I think we have to make sure the release artifacts are enable the OS update
I meant this one https://github.com/apache/flink-kubernetes-operator/blob/1dd9850fb37d4f7d572f46b247470bda13fb3660/.github/workflows/ci.yml#L66. So that the e2e test run with the configuration that we'll release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] Aitozi commented on pull request #266: [FLINK-27960] Make the apt-get updating optional
Posted by GitBox <gi...@apache.org>.
Aitozi commented on PR #266:
URL: https://github.com/apache/flink-kubernetes-operator/pull/266#issuecomment-1154965530
Hi @morhidi do you mean I do not add the in `.github/workflows/docker-bake.hcl` ?
```
args = {
SKIP_OS_UPDATE = false
}
```
Is this file will be used to build the release artifacts? I think we have to make sure the release artifacts are enable the OS update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] Aitozi commented on pull request #266: [FLINK-27960] Make the apt-get updating optional
Posted by GitBox <gi...@apache.org>.
Aitozi commented on PR #266:
URL: https://github.com/apache/flink-kubernetes-operator/pull/266#issuecomment-1154990219
@morhidi Get your meaning, make sense to me. Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora merged pull request #266: [FLINK-27960] Make the apt-get updating optional
Posted by GitBox <gi...@apache.org>.
gyfora merged PR #266:
URL: https://github.com/apache/flink-kubernetes-operator/pull/266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #266: [FLINK-27960] Make the apt-get updating optional
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #266:
URL: https://github.com/apache/flink-kubernetes-operator/pull/266#issuecomment-1154879533
+1 on the feature @Aitozi. IMO we can go with `SKIP_OS_UPDATE=true` by default, that would affect local builds only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] Aitozi commented on pull request #266: [FLINK-27960] Make the apt-get updating optional
Posted by GitBox <gi...@apache.org>.
Aitozi commented on PR #266:
URL: https://github.com/apache/flink-kubernetes-operator/pull/266#issuecomment-1154012456
@mbalassi Thanks for your detail explanation. I finally choose to use different options 😄 and set the default `SKIP_OS_UPDATE` to false, It's for the security consideration :).
The main reason I want to use two options is that we can skip tests and not skip update os when building the final artifacts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #266: [FLINK-27960] Make the apt-get updating optional
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #266:
URL: https://github.com/apache/flink-kubernetes-operator/pull/266#issuecomment-1154959910
We can use the `SKIP_OS_UPDATE=false` in the CI workflow two. Not sure how much it adds to the build process but on OS upgrade can pull in some regression too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org