You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Matthias Bläsing <mb...@doppel-helix.eu> on 2021/10/12 17:38:36 UTC
Debugging Broken in NetBeans master - PLEASE DO NOT MERGE FURTHER
CHANGES
Hi,
I want to raise awareness of the broken state of debugging in NetBeans
IDE. I raise it here and now, because reverting the initial changes
alone does not help anymore.
The problem starts with this PR:
https://github.com/apache/netbeans/pull/3158
that was reverted via
https://github.com/apache/netbeans/pull/3181
and resubmitted as
https://github.com/apache/netbeans/pull/3204
After the merge of PR3204 it looked ok, but I did not test with
"Suspend all threads" and this is now totally broken in NetBeans
master.
See the final comment in PR 3204 for a description of the issue.
The big question is: What to do about this? A trivial revert fails as
there are conflicting changes in the area.
The best case scenario: Debugging will be fixed and be stable again as
it was in the past.
Worst case scenario: We revert all changes, that touch the JPDA code
and everything, that causes conflicts.
I would prefer the best case scenario.
Greetings
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [External] : Debugging Broken in NetBeans master - PLEASE DO NOT
MERGE FURTHER CHANGES
Posted by Neil C Smith <ne...@apache.org>.
On Wed, 13 Oct 2021 at 09:00, Martin Entlicher
<ma...@oracle.com> wrote:
> I'd say that the best approach in this case is to create an issue for this problem and fix the issue.
> I did not notice that others would revert their work as soon as a bug occurs. Everyone introduces a bug from time to time. And usually, we're able to fix them.
>
> The given commit was a bit more risky as it had to touch the core functionality. It usually takes some time till the product is completely tested.
Personally I think Matthias took the right approach here, and in fact
an approach I think we should take more often (hence my +1 comment on
the revert PR).
We agreed to work under the general principle of keeping master
releasable. The issue had been raised on the original PR for almost a
week before the revert PR, which was also open almost a week before
integrating.
> Thanks for finding it, I'm going to address the issue...
Thanks. Will keep an eye for it. Am about to do an email delaying
freeze for a week to try and get nb-javac in. Be good to get this
issue fully fixed before then too.
Best wishes,
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [External] : Debugging Broken in NetBeans master - PLEASE DO
NOT MERGE FURTHER CHANGES
Posted by Matthias Bläsing <mb...@doppel-helix.eu>.
Hi,
Am Mittwoch, dem 13.10.2021 um 07:59 +0000 schrieb Martin Entlicher:
> I did not notice that others would revert their work as soon as a bug
> occurs. Everyone introduces a bug from time to time. And usually,
> we're able to fix them.
thank you for the quick fix in PR #3244.
As I was questioned why I did go directly go to "lets revert": No this
would not be a normal reaction, but it is always on the table.
This case there is special, as it has a history. The first time I hit a
problem in this area and could pin-point it onto the performance
enhancement PR, this timeline happend:
- I reported the issue with the PR as a comment in the PR
- 6 days later I opened a PR, that reverted the problematic PR
and requested a review from both persons involved in the orginal PR
- 14 day later I merged the revert commit, as there was no comment
asking for more time and broke a core feature (at least for me)
Yes I might have exaggerated here and I apologize for that, this hit a
raw nerve. I appreciate the work!
Greetings
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [External] : Debugging Broken in NetBeans master - PLEASE DO NOT
MERGE FURTHER CHANGES
Posted by Martin Entlicher <ma...@oracle.com>.
I'd say that the best approach in this case is to create an issue for this problem and fix the issue.
I did not notice that others would revert their work as soon as a bug occurs. Everyone introduces a bug from time to time. And usually, we're able to fix them.
The given commit was a bit more risky as it had to touch the core functionality. It usually takes some time till the product is completely tested.
I'll create an issue for this problem.
Thanks for finding it, I'm going to address the issue...
Regards,
Martin
________________________________
From: Matthias Bl?sing <mb...@doppel-helix.eu>
Sent: Tuesday, October 12, 2021 19:38
To: dev@netbeans.apache.org <de...@netbeans.apache.org>
Subject: [External] : Debugging Broken in NetBeans master - PLEASE DO NOT MERGE FURTHER CHANGES
Hi,
I want to raise awareness of the broken state of debugging in NetBeans
IDE. I raise it here and now, because reverting the initial changes
alone does not help anymore.
The problem starts with this PR:
https://urldefense.com/v3/__https://github.com/apache/netbeans/pull/3158__;!!ACWV5N9M2RV99hQ!ebawpzNS-ocoZ2a4VAyEURgvqtT2yArecJIJ7Vm7ljt_EZmpzfl7vLc6Y8jSXXwwoFcL$
that was reverted via
https://urldefense.com/v3/__https://github.com/apache/netbeans/pull/3181__;!!ACWV5N9M2RV99hQ!ebawpzNS-ocoZ2a4VAyEURgvqtT2yArecJIJ7Vm7ljt_EZmpzfl7vLc6Y8jSXTmAPyF_$
and resubmitted as
https://urldefense.com/v3/__https://github.com/apache/netbeans/pull/3204__;!!ACWV5N9M2RV99hQ!ebawpzNS-ocoZ2a4VAyEURgvqtT2yArecJIJ7Vm7ljt_EZmpzfl7vLc6Y8jSXdVwV0lx$
After the merge of PR3204 it looked ok, but I did not test with
"Suspend all threads" and this is now totally broken in NetBeans
master.
See the final comment in PR 3204 for a description of the issue.
The big question is: What to do about this? A trivial revert fails as
there are conflicting changes in the area.
The best case scenario: Debugging will be fixed and be stable again as
it was in the past.
Worst case scenario: We revert all changes, that touch the JPDA code
and everything, that causes conflicts.
I would prefer the best case scenario.
Greetings
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://urldefense.com/v3/__https://cwiki.apache.org/confluence/display/NETBEANS/Mailing*lists__;Kw!!ACWV5N9M2RV99hQ!ebawpzNS-ocoZ2a4VAyEURgvqtT2yArecJIJ7Vm7ljt_EZmpzfl7vLc6Y8jSXQftsm-o$
Re: Debugging Broken in NetBeans master - PLEASE DO NOT MERGE FURTHER CHANGES
Posted by Brad Walker <bw...@musings.com>.
Kinda curious as to what happened with this?
Did we get debugging fixed?
-brad w.
On Tue, Oct 12, 2021 at 11:38 AM Matthias Bläsing <mb...@doppel-helix.eu>
wrote:
> Hi,
>
> I want to raise awareness of the broken state of debugging in NetBeans
> IDE. I raise it here and now, because reverting the initial changes
> alone does not help anymore.
>
> The problem starts with this PR:
>
> https://github.com/apache/netbeans/pull/3158
>
> that was reverted via
>
> https://github.com/apache/netbeans/pull/3181
>
> and resubmitted as
>
> https://github.com/apache/netbeans/pull/3204
>
> After the merge of PR3204 it looked ok, but I did not test with
> "Suspend all threads" and this is now totally broken in NetBeans
> master.
>
> See the final comment in PR 3204 for a description of the issue.
>
> The big question is: What to do about this? A trivial revert fails as
> there are conflicting changes in the area.
>
> The best case scenario: Debugging will be fixed and be stable again as
> it was in the past.
>
> Worst case scenario: We revert all changes, that touch the JPDA code
> and everything, that causes conflicts.
>
> I would prefer the best case scenario.
>
> Greetings
>
> Matthias
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
Re: Debugging Broken in NetBeans master - PLEASE DO NOT MERGE FURTHER CHANGES
Posted by Matthias Bläsing <mb...@doppel-helix.eu>.
Hi,
sorry, yes merges are ok. The intention here was to prevent more merges, that could hinder a revert. As Martin did the best thing and fixed the issue, that is not needed anymore.
Greetings
Matthias
Am 15. Oktober 2021 06:56:54 MESZ schrieb "László Kishalmi" <la...@gmail.com>:
>Is master open for merges after https://github.com/apache/netbeans/pull/3244
>?
>
>On Tue, Oct 12, 2021 at 10:22 PM Jaroslav Tulach <ja...@gmail.com>
>wrote:
>
>> > PLEASE DO NOT MERGE FURTHER CHANGES
>>
>> I can see that the revert PR-3181 wasn't approved by Martin Entlicher and
>> that
>> his another PR-3204 hasn't been reviewed and approved by you.
>>
>> Looks like serious communication breakdown. Thanks for letting us know
>> before
>> starting another round of reverts.
>>
>> > What to do about this? The best case scenario:
>>
>> Treat this as a bug, talk to each other, make debugger work in 12.6 and
>> let
>> make the debugger work fast.
>> -jt
>>
>> > Hi,
>> >
>> > I want to raise awareness of the broken state of debugging in NetBeans
>> > IDE. I raise it here and now, because reverting the initial changes
>> > alone does not help anymore.
>> >
>> > The problem starts with this PR:
>> >
>> > https://github.com/apache/netbeans/pull/3158
>> >
>> > that was reverted via
>> >
>> > https://github.com/apache/netbeans/pull/3181
>> >
>> > and resubmitted as
>> >
>> > https://github.com/apache/netbeans/pull/3204
>> >
>> > After the merge of PR3204 it looked ok, but I did not test with
>> > "Suspend all threads" and this is now totally broken in NetBeans
>> > master.
>> >
>> > See the final comment in PR 3204 for a description of the issue.
>> >
>> > The big question is: What to do about this? A trivial revert fails as
>> > there are conflicting changes in the area.
>> >
>> > The best case scenario: Debugging will be fixed and be stable again as
>> > it was in the past.
>> >
>> > Worst case scenario: We revert all changes, that touch the JPDA code
>> > and everything, that causes conflicts.
>> >
>> > I would prefer the best case scenario.
>> >
>> > Greetings
>> >
>> > Matthias
>> >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
>> > For additional commands, e-mail: dev-help@netbeans.apache.org
>> >
>> > For further information about the NetBeans mailing lists, visit:
>> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
>> For additional commands, e-mail: dev-help@netbeans.apache.org
>>
>> For further information about the NetBeans mailing lists, visit:
>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>
>>
>>
>>
Re: Debugging Broken in NetBeans master - PLEASE DO NOT MERGE FURTHER CHANGES
Posted by László Kishalmi <la...@gmail.com>.
Is master open for merges after https://github.com/apache/netbeans/pull/3244
?
On Tue, Oct 12, 2021 at 10:22 PM Jaroslav Tulach <ja...@gmail.com>
wrote:
> > PLEASE DO NOT MERGE FURTHER CHANGES
>
> I can see that the revert PR-3181 wasn't approved by Martin Entlicher and
> that
> his another PR-3204 hasn't been reviewed and approved by you.
>
> Looks like serious communication breakdown. Thanks for letting us know
> before
> starting another round of reverts.
>
> > What to do about this? The best case scenario:
>
> Treat this as a bug, talk to each other, make debugger work in 12.6 and
> let
> make the debugger work fast.
> -jt
>
> > Hi,
> >
> > I want to raise awareness of the broken state of debugging in NetBeans
> > IDE. I raise it here and now, because reverting the initial changes
> > alone does not help anymore.
> >
> > The problem starts with this PR:
> >
> > https://github.com/apache/netbeans/pull/3158
> >
> > that was reverted via
> >
> > https://github.com/apache/netbeans/pull/3181
> >
> > and resubmitted as
> >
> > https://github.com/apache/netbeans/pull/3204
> >
> > After the merge of PR3204 it looked ok, but I did not test with
> > "Suspend all threads" and this is now totally broken in NetBeans
> > master.
> >
> > See the final comment in PR 3204 for a description of the issue.
> >
> > The big question is: What to do about this? A trivial revert fails as
> > there are conflicting changes in the area.
> >
> > The best case scenario: Debugging will be fixed and be stable again as
> > it was in the past.
> >
> > Worst case scenario: We revert all changes, that touch the JPDA code
> > and everything, that causes conflicts.
> >
> > I would prefer the best case scenario.
> >
> > Greetings
> >
> > Matthias
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> > For additional commands, e-mail: dev-help@netbeans.apache.org
> >
> > For further information about the NetBeans mailing lists, visit:
> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
Re: Debugging Broken in NetBeans master - PLEASE DO NOT MERGE FURTHER CHANGES
Posted by Jaroslav Tulach <ja...@gmail.com>.
> PLEASE DO NOT MERGE FURTHER CHANGES
I can see that the revert PR-3181 wasn't approved by Martin Entlicher and that
his another PR-3204 hasn't been reviewed and approved by you.
Looks like serious communication breakdown. Thanks for letting us know before
starting another round of reverts.
> What to do about this? The best case scenario:
Treat this as a bug, talk to each other, make debugger work in 12.6 and let
make the debugger work fast.
-jt
> Hi,
>
> I want to raise awareness of the broken state of debugging in NetBeans
> IDE. I raise it here and now, because reverting the initial changes
> alone does not help anymore.
>
> The problem starts with this PR:
>
> https://github.com/apache/netbeans/pull/3158
>
> that was reverted via
>
> https://github.com/apache/netbeans/pull/3181
>
> and resubmitted as
>
> https://github.com/apache/netbeans/pull/3204
>
> After the merge of PR3204 it looked ok, but I did not test with
> "Suspend all threads" and this is now totally broken in NetBeans
> master.
>
> See the final comment in PR 3204 for a description of the issue.
>
> The big question is: What to do about this? A trivial revert fails as
> there are conflicting changes in the area.
>
> The best case scenario: Debugging will be fixed and be stable again as
> it was in the past.
>
> Worst case scenario: We revert all changes, that touch the JPDA code
> and everything, that causes conflicts.
>
> I would prefer the best case scenario.
>
> Greetings
>
> Matthias
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists