You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/10/19 10:16:38 UTC

[GitHub] [iotdb] JulianFeinauer commented on a change in pull request #1793: IOTDB-932 Removed (wrong and redundant) Verification of Paths in Sess…

JulianFeinauer commented on a change in pull request #1793:
URL: https://github.com/apache/iotdb/pull/1793#discussion_r507632599



##########
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##########
@@ -1649,15 +1632,6 @@ protected TSStatus executeNonQueryPlan(PhysicalPlan plan) {
         : RpcUtils.getStatus(TSStatusCode.EXECUTE_STATEMENT_ERROR);
   }
 
-  private TSStatus checkPathValidity(String path) {
-    if (!PATH_PATTERN.matcher(path).matches()) {

Review comment:
       Good catch, thanks. Indeed I just pushed an Update and if tests are okay I will merge!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org