You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2009/09/30 17:49:23 UTC

[jira] Created: (QPID-2121) Allow QpidTestCase to set System Properties on external broker VMs.

Allow QpidTestCase to set System Properties on external broker VMs.
-------------------------------------------------------------------

                 Key: QPID-2121
                 URL: https://issues.apache.org/jira/browse/QPID-2121
             Project: Qpid
          Issue Type: Improvement
          Components: Java Tests
    Affects Versions: 0.5
            Reporter: Martin Ritchie
            Priority: Minor
             Fix For: 0.6


Currently system properties can be set for the test VM via setSystemProperty. Values set here are also currently copied to the external broker. However, there are times when you want the test to have a custom system property but not have that value copied to the broker.

One such time is in BrokerLoggingTest#testStartupDefaultLog4j. A custom broker.ready value is needed and if copied to the broker it will be echo as part of the command line and trigger the QTC to continue.

As solution is to provide two additional set*SystemProperty metdhosd : setBrokerOnlySystemProperty and setTestOnlySystemProperty.
This allows the various VMs to be configured differently, whilst leaving the functionality of setSystemProperty of copying the value to all VMs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Resolved: (QPID-2121) Allow QpidTestCase to set System Properties on external broker VMs.

Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marnie McCormack resolved QPID-2121.
------------------------------------

    Resolution: Fixed

Remove random ; on line 197

> Allow QpidTestCase to set System Properties on external broker VMs.
> -------------------------------------------------------------------
>
>                 Key: QPID-2121
>                 URL: https://issues.apache.org/jira/browse/QPID-2121
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Tests
>    Affects Versions: 0.5
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>            Priority: Minor
>             Fix For: 0.6
>
>
> Currently system properties can be set for the test VM via setSystemProperty. Values set here are also currently copied to the external broker. However, there are times when you want the test to have a custom system property but not have that value copied to the broker.
> One such time is in BrokerLoggingTest#testStartupDefaultLog4j. A custom broker.ready value is needed and if copied to the broker it will be echo as part of the command line and trigger the QTC to continue.
> As solution is to provide two additional set*SystemProperty metdhosd : setBrokerOnlySystemProperty and setTestOnlySystemProperty.
> This allows the various VMs to be configured differently, whilst leaving the functionality of setSystemProperty of copying the value to all VMs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Assigned: (QPID-2121) Allow QpidTestCase to set System Properties on external broker VMs.

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie reassigned QPID-2121:
------------------------------------

    Assignee: Martin Ritchie

> Allow QpidTestCase to set System Properties on external broker VMs.
> -------------------------------------------------------------------
>
>                 Key: QPID-2121
>                 URL: https://issues.apache.org/jira/browse/QPID-2121
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Tests
>    Affects Versions: 0.5
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>            Priority: Minor
>             Fix For: 0.6
>
>
> Currently system properties can be set for the test VM via setSystemProperty. Values set here are also currently copied to the external broker. However, there are times when you want the test to have a custom system property but not have that value copied to the broker.
> One such time is in BrokerLoggingTest#testStartupDefaultLog4j. A custom broker.ready value is needed and if copied to the broker it will be echo as part of the command line and trigger the QTC to continue.
> As solution is to provide two additional set*SystemProperty metdhosd : setBrokerOnlySystemProperty and setTestOnlySystemProperty.
> This allows the various VMs to be configured differently, whilst leaving the functionality of setSystemProperty of copying the value to all VMs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2121) Allow QpidTestCase to set System Properties on external broker VMs.

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie updated QPID-2121:
---------------------------------

    Status: Ready To Review  (was: In Progress)

> Allow QpidTestCase to set System Properties on external broker VMs.
> -------------------------------------------------------------------
>
>                 Key: QPID-2121
>                 URL: https://issues.apache.org/jira/browse/QPID-2121
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Tests
>    Affects Versions: 0.5
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>            Priority: Minor
>             Fix For: 0.6
>
>
> Currently system properties can be set for the test VM via setSystemProperty. Values set here are also currently copied to the external broker. However, there are times when you want the test to have a custom system property but not have that value copied to the broker.
> One such time is in BrokerLoggingTest#testStartupDefaultLog4j. A custom broker.ready value is needed and if copied to the broker it will be echo as part of the command line and trigger the QTC to continue.
> As solution is to provide two additional set*SystemProperty metdhosd : setBrokerOnlySystemProperty and setTestOnlySystemProperty.
> This allows the various VMs to be configured differently, whilst leaving the functionality of setSystemProperty of copying the value to all VMs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org