You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2023/01/11 15:59:21 UTC

[GitHub] [flink] lsyldliu commented on a diff in pull request #21608: [FLINK-29721][hive] Supports native hive min function for hive dialect

lsyldliu commented on code in PR #21608:
URL: https://github.com/apache/flink/pull/21608#discussion_r1067164508


##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/module/hive/HiveModule.java:
##########
@@ -81,6 +82,18 @@ public class HiveModule implements Module {
                                     "tumble_rowtime",
                                     "tumble_start")));
 
+    static final Set<String> FLINK_BUILT_IN_FUNC_FOR_HIVE =

Review Comment:
   In [FLINK-30579](https://github.com/apache/flink/pull/21629) pr, we will introduce an option to enable native hive sum aggregate function, so I think this set should only contain the agg function name, and exclude other functions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org