You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by "Ralph Goers (JIRA)" <ji...@apache.org> on 2017/08/21 04:06:00 UTC

[jira] [Comment Edited] (LOG4J2-1086) SizeBasedTriggeringPolicy is not working properly

    [ https://issues.apache.org/jira/browse/LOG4J2-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134684#comment-16134684 ] 

Ralph Goers edited comment on LOG4J2-1086 at 8/21/17 4:05 AM:
--------------------------------------------------------------

Perrick,

The test creates 100 Excectuors on 32 threads. Each of those 100 workers is likely to pass through the SizeBasedTriggeringPolicy check before any data is written to disk. At a size of 30-32 bytes you are looking at over 3000 bytes to be written. Then as the data is being written the workers will keep writing more events until the number of bytes finally exceeds the max file size. At that time there will be 99 events in the process of being written ahead of the thread that is going to perform the rollover.

In short, the file is rolling over but I don't believe the granularity can be guaranteed at that fine a level. 

I doubt that this test accurately reflects what might be going on when the size is set to 10KB and the file doesn't roll over.


was (Author: ralph.goers@dslextreme.com):
Perrick,

The creates 100 Excectuors on 32 threads. Each of those 100 workers is likely to pass through the SizeBasedTriggeringPolicy check before any data is written to disk. At a size of 30-32 bytes you are looking at over 3000 bytes to be written. Then as the data is being written the workers will keep writing more events until the number of bytes finally exceeds the max file size. At that time there will be 99 events in the process of being written ahead of the thread that is going to perform the rollover.

In short, the file is rolling over but I don't believe the granularity can be guaranteed at that fine a level. 

I doubt that this test accurately reflects what might be going on when the size is set to 10KB and the file doesn't roll over.

> SizeBasedTriggeringPolicy is not working properly
> -------------------------------------------------
>
>                 Key: LOG4J2-1086
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1086
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Appenders
>    Affects Versions: 2.3, 2.4.1, 2.8
>         Environment: Windows 7 OS Websphere 8.5.5.6
>            Reporter: Sharat
>            Assignee: Ralph Goers
>            Priority: Minor
>              Labels: features
>         Attachments: LOG4J2-1086.Test.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> {code}
> <?xml version="1.0" encoding="UTF-8"?>
> <Configuration>
> <Appenders> 
> 		<RollingFile name="RollingFile" fileName="/logs/test.log" 
> 			filePattern="/logs/test-%i.log"> 
> 			<PatternLayout> 
> 				<pattern>%d %-5p %class{36} (%M:%L) -%msg%xEx%n</pattern> 
> 			</PatternLayout> 
> 			<Policies> 
> 				<SizeBasedTriggeringPolicy size="2 KB" />
> 			</Policies>
> 			<DefaultRolloverStrategy max="5"/> 
> 		</RollingFile> 
> 		<Console name="console" target="SYSTEM_OUT"> 
> 			<PatternLayout pattern="%d{HH:mm:ss.SSS} [%t] %-5level %logger{36} - %msg%n"/> 
> 		</Console> 
> 	</Appenders> 
> 	<Loggers>
> 	    <root level="trace">
> 		  <appender-ref ref="RollingFile"/> 
> 	      <appender-ref ref="console"/>
> 	    </root>
> 	</Loggers>
> </Configuration>
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)