You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/14 15:45:15 UTC
[GitHub] [doris] morningman opened a new pull request, #15934: [refactor](doc) add new first class catalog lakehouse for multi catalog and external table
morningman opened a new pull request, #15934:
URL: https://github.com/apache/doris/pull/15934
# Proposed changes
Issue Number: close #xxx
## Problem summary
I change the doc of multi-catalog and external table.
Now there will be a first-class category named "Lakehouse" in doc sidebar.
And the doc will be reorganized as:
```
lakehouse/
├── external-table
│ ├── es.md
│ ├── file.md
│ ├── hive.md
│ ├── jdbc.md
│ └── odbc.md
└── multi-catalog
├── dlf.md
├── es.md
├── faq.md
├── hive.md
├── hudi.md
├── iceberg.md
├── jdbc.md
└── multi-catalog.md
```
Multi catalog and external table docs is no longer in `Ecosystem` category.
TODO:
I didn't write the english version, I will first checkout the result of Chinese docs,
and then add english doc later.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jeffreys-cat commented on a diff in pull request #15934: [refactor](doc) add first class category "lakehouse" for multi catalog and external table
Posted by GitBox <gi...@apache.org>.
jeffreys-cat commented on code in PR #15934:
URL: https://github.com/apache/doris/pull/15934#discussion_r1070625301
##########
docs/dev.json:
##########
@@ -290,5 +286,17 @@
"sidebar.docs.category.Benchmark": {
"message": "性能测试",
"description": "The label for category Benchmark in sidebar docs"
+ },
+ "sidebar.docs.category.Lakehouse": {
+ "message": "数据湖分析",
+ "description": "The label for category Lakehouse in sidebar docs"
+ }
Review Comment:
Expected comma here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15934: [refactor](doc) add first class category "lakehouse" for multi catalog and external table
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15934:
URL: https://github.com/apache/doris/pull/15934#issuecomment-1383331324
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15934: [refactor](doc) add first class category "lakehouse" for multi catalog and external table
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15934:
URL: https://github.com/apache/doris/pull/15934#issuecomment-1383331348
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #15934: [refactor](doc) add first class category "lakehouse" for multi catalog and external table
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #15934:
URL: https://github.com/apache/doris/pull/15934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org