You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/02 00:43:20 UTC

[GitHub] [arrow-rs] helgikrs opened a new pull request #1379: feat: support maps in MutableArrayData

helgikrs opened a new pull request #1379:
URL: https://github.com/apache/arrow-rs/pull/1379


   # Which issue does this PR close?
   
   Closes #1378.
   
   # Rationale for this change
   
   Filter uses `MutableArrayData` internally. So this change allows the use of `fliter` on record batches and arrays containing maps.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on a change in pull request #1379: feat: support maps in MutableArrayData

Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #1379:
URL: https://github.com/apache/arrow-rs/pull/1379#discussion_r818919066



##########
File path: arrow/src/array/transform/mod.rs
##########
@@ -516,8 +522,8 @@ impl<'a> MutableArrayData<'a> {
                     })
                     .collect::<Vec<_>>(),
             },
-            _ => {
-                todo!("Take and filter operations still not supported for this datatype")
+            ty => {
+                todo!("Take and filter operations still not supported for this datatype: `{:?}`", ty)

Review comment:
       Thank you for also improving the error messages




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb merged pull request #1379: feat: support maps in MutableArrayData

Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1379:
URL: https://github.com/apache/arrow-rs/pull/1379


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org