[GitHub] [helix] dasahcc commented on a change in pull request #647: Add java API to create cluster with CloudConfig

[GitBox <gi...@apache.org>]

dasahcc commented on a change in pull request #647: Add java API to create cluster with CloudConfig
URL: https://github.com/apache/helix/pull/647#discussion_r362569842
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
 ##########
 @@ -90,7 +86,7 @@ public CloudConfig(String cluster, boolean enabled, CloudProvider cloudProvider,
    * Enable/Disable the CLOUD_ENABLED field.
    * @param enabled
    */
-  public void setCloudEnabled(boolean enabled) {
+  private void setCloudEnabled(boolean enabled) {
 
 Review comment:
   These methods are/can not used by any place. Instead of removing all, we can keep some of the them as public ones. We need to leave the room to let user change some of the fields, such as cloudenable, source fields.
   
   For validation purpose, we can make all constructors private and creating through Builder.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org