You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Ali Sadik Kumlali (JIRA)" <ji...@apache.org> on 2006/05/17 08:20:05 UTC
[jira] Created: (AXIS2-746) Missing error explanations in
AxisServlet
Missing error explanations in AxisServlet
-----------------------------------------
Key: AXIS2-746
URL: http://issues.apache.org/jira/browse/AXIS2-746
Project: Apache Axis 2.0 (Axis2)
Type: Improvement
Components: core
Environment: Win2K Pro, JDK 1.4, Tomcat 5.5
Reporter: Ali Sadik Kumlali
catch block found in doPost method doesn't print the actual error but prints "org.apache.axis2.AxisFault".
In 405768 revision
--------------------------
} catch (AxisFault e) {
log.debug(e);
if (msgContext != null) {
try {
res.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
handleFault(msgContext, out, e);
} catch (AxisFault e2) {
log.info(e2);
}
} else {
throw new ServletException(e);
}
}
Should be
---------------
} catch (AxisFault e) {
log.debug("bla bla", e); // or log.debug(e.getMessage());
if (msgContext != null) {
try {
res.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
handleFault(msgContext, out, e);
} catch (AxisFault e2) {
log.info("bla bla2",e2); // or log.info(e.getMessage());
}
} else {
throw new ServletException(e);
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (AXIS2-746) Missing error explanations in
AxisServlet
Posted by "Ali Sadik Kumlali (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-746?page=comments#action_12434381 ]
Ali Sadik Kumlali commented on AXIS2-746:
-----------------------------------------
You seem right Deepal. After your comment, I made some trials with the logging framework and came to a conclusion:
Code:
-------------
Exception ex = new Exception ();
log.debug(ex);
ex = new Exception ("Actual error message");
log.debug(ex);
ex = new Exception (new Exception());
log.debug(ex);
ex = new Exception (new Exception("Actual error message"));
log.debug(ex);
Output:
-------------
[DEBUG] logtest.TestLog4j - java.lang.Exception
[DEBUG] logtest.TestLog4j - java.lang.Exception: Actual error message
[DEBUG] logtest.TestLog4j - java.lang.Exception: java.lang.Exception
[DEBUG] logtest.TestLog4j - java.lang.Exception: java.lang.Exception: Actual error message
Conclusion
---------------
- Creating exceptions without passing to them the actual message, causes lack of information such as java.lang.Exception and org.apache.axis2.AxisFault.
- If an exception is created without passing it a message and this exception is passed to constructor of another exception, the same thing happens.
- If I see a log that says "org.apache.axis2.AxisFault" only, there must be a "new AxisFault()" or "new AxisFault(ex)" where ex must be created similar to "new Exception()".
- I've searched all the code base and couldn't find "new AxisFault()"
- Therefore, some of the exceptions that is passed to constructor of AxisFault *must* be created without passing them a message. In this case, Axis2 has nothing to do.
> Missing error explanations in AxisServlet
> -----------------------------------------
>
> Key: AXIS2-746
> URL: http://issues.apache.org/jira/browse/AXIS2-746
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: core
> Environment: Win2K Pro, JDK 1.4, Tomcat 5.5
> Reporter: Ali Sadik Kumlali
> Assigned To: Deepal Jayasinghe
>
> catch block found in doPost method doesn't print the actual error but prints "org.apache.axis2.AxisFault".
>
> In 405768 revision
> --------------------------
> } catch (AxisFault e) {
> log.debug(e);
> if (msgContext != null) {
> try {
> res.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
> handleFault(msgContext, out, e);
> } catch (AxisFault e2) {
> log.info(e2);
> }
> } else {
> throw new ServletException(e);
> }
> }
> Should be
> ---------------
> } catch (AxisFault e) {
> log.debug("bla bla", e); // or log.debug(e.getMessage());
> if (msgContext != null) {
> try {
> res.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
> handleFault(msgContext, out, e);
> } catch (AxisFault e2) {
> log.info("bla bla2",e2); // or log.info(e.getMessage());
> }
> } else {
> throw new ServletException(e);
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-746) Missing error explanations in
AxisServlet
Posted by "Ali Sadik Kumlali (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-746?page=comments#action_12412112 ]
Ali Sadik Kumlali commented on AXIS2-746:
-----------------------------------------
Oops! e.getMessage() doesn't work. FYI.
> Missing error explanations in AxisServlet
> -----------------------------------------
>
> Key: AXIS2-746
> URL: http://issues.apache.org/jira/browse/AXIS2-746
> Project: Apache Axis 2.0 (Axis2)
> Type: Improvement
> Components: core
> Environment: Win2K Pro, JDK 1.4, Tomcat 5.5
> Reporter: Ali Sadik Kumlali
>
> catch block found in doPost method doesn't print the actual error but prints "org.apache.axis2.AxisFault".
>
> In 405768 revision
> --------------------------
> } catch (AxisFault e) {
> log.debug(e);
> if (msgContext != null) {
> try {
> res.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
> handleFault(msgContext, out, e);
> } catch (AxisFault e2) {
> log.info(e2);
> }
> } else {
> throw new ServletException(e);
> }
> }
> Should be
> ---------------
> } catch (AxisFault e) {
> log.debug("bla bla", e); // or log.debug(e.getMessage());
> if (msgContext != null) {
> try {
> res.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
> handleFault(msgContext, out, e);
> } catch (AxisFault e2) {
> log.info("bla bla2",e2); // or log.info(e.getMessage());
> }
> } else {
> throw new ServletException(e);
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (AXIS2-746) Missing error explanations in
AxisServlet
Posted by "Deepal Jayasinghe (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-746?page=all ]
Deepal Jayasinghe reassigned AXIS2-746:
---------------------------------------
Assign To: Deepal Jayasinghe
> Missing error explanations in AxisServlet
> -----------------------------------------
>
> Key: AXIS2-746
> URL: http://issues.apache.org/jira/browse/AXIS2-746
> Project: Apache Axis 2.0 (Axis2)
> Type: Improvement
> Components: core
> Environment: Win2K Pro, JDK 1.4, Tomcat 5.5
> Reporter: Ali Sadik Kumlali
> Assignee: Deepal Jayasinghe
>
> catch block found in doPost method doesn't print the actual error but prints "org.apache.axis2.AxisFault".
>
> In 405768 revision
> --------------------------
> } catch (AxisFault e) {
> log.debug(e);
> if (msgContext != null) {
> try {
> res.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
> handleFault(msgContext, out, e);
> } catch (AxisFault e2) {
> log.info(e2);
> }
> } else {
> throw new ServletException(e);
> }
> }
> Should be
> ---------------
> } catch (AxisFault e) {
> log.debug("bla bla", e); // or log.debug(e.getMessage());
> if (msgContext != null) {
> try {
> res.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
> handleFault(msgContext, out, e);
> } catch (AxisFault e2) {
> log.info("bla bla2",e2); // or log.info(e.getMessage());
> }
> } else {
> throw new ServletException(e);
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Resolved: (AXIS2-746) Missing error explanations in
AxisServlet
Posted by "Deepal Jayasinghe (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-746?page=all ]
Deepal Jayasinghe resolved AXIS2-746.
-------------------------------------
Resolution: Won't Fix
If that is the case , how can we fix that.
Any way when we are doing i18n we can improve all these (we have to)
> Missing error explanations in AxisServlet
> -----------------------------------------
>
> Key: AXIS2-746
> URL: http://issues.apache.org/jira/browse/AXIS2-746
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: core
> Environment: Win2K Pro, JDK 1.4, Tomcat 5.5
> Reporter: Ali Sadik Kumlali
> Assigned To: Deepal Jayasinghe
>
> catch block found in doPost method doesn't print the actual error but prints "org.apache.axis2.AxisFault".
>
> In 405768 revision
> --------------------------
> } catch (AxisFault e) {
> log.debug(e);
> if (msgContext != null) {
> try {
> res.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
> handleFault(msgContext, out, e);
> } catch (AxisFault e2) {
> log.info(e2);
> }
> } else {
> throw new ServletException(e);
> }
> }
> Should be
> ---------------
> } catch (AxisFault e) {
> log.debug("bla bla", e); // or log.debug(e.getMessage());
> if (msgContext != null) {
> try {
> res.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
> handleFault(msgContext, out, e);
> } catch (AxisFault e2) {
> log.info("bla bla2",e2); // or log.info(e.getMessage());
> }
> } else {
> throw new ServletException(e);
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org