You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "Cole-Greer (via GitHub)" <gi...@apache.org> on 2023/05/12 00:38:48 UTC
[GitHub] [tinkerpop] Cole-Greer opened a new pull request, #2063: 3.6: fixing licenses/NOTICE for console and server distributions
Cole-Greer opened a new pull request, #2063:
URL: https://github.com/apache/tinkerpop/pull/2063
Fixing some issues found during the release of 3.5.6/3.6.4.
Noteworthy that mockito-core is being added to the licenses folder as it is currently included in the lib directory in the distributions for both console and server. I believe this inclusion is likely a mistake and should be investigated and removed at a later date. I have opted to leave it in and correct the licensing for now as I don't believe such a change should be made right before the 3.6.4 patch release gets made.
Additionally adding static NOTICE and licenses files for gremlin-shaded for inclusion in the shaded jar. Also updates notices for console and server as their distributions include gremlin-shaded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer commented on a diff in pull request #2063: 3.6: fixing licenses/NOTICE for console and server distributions
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on code in PR #2063:
URL: https://github.com/apache/tinkerpop/pull/2063#discussion_r1192665926
##########
gremlin-server/src/main/static/NOTICE:
##########
@@ -64,3 +64,29 @@ HPPC borrowed code, ideas or both from:
Netty 4.1.86
------------------------------------------------------------------------
Copyright 2014 The Netty Project
+
+------------------------------------------------------------------------
+Objenesis 2.4 (Included through gremlin-shaded)
+------------------------------------------------------------------------
+Copyright 2006-2016 Joe Walnes, Henri Tremblay, Leonardo Mesquita
+
+------------------------------------------------------------------------
+Jackson-Databind 2.14.0 and Jackson-Core (Included through gremlin-shaded)
Review Comment:
I want to push for a slightly less abbreviated version as
> It was originally written by Tatu Saloranta (tatu.saloranta@iki.fi), and has been in development since 2007.
> It is currently developed by a community of developers.
The original notice has a clear intent to give attribution to the community in addition to the original author and I believe we should preserve that. I've updated the notice accordingly (and fixed the ordering). If you still think a shorter version is preferable I can update it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer commented on a diff in pull request #2063: 3.6: fixing licenses/NOTICE for console and server distributions
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on code in PR #2063:
URL: https://github.com/apache/tinkerpop/pull/2063#discussion_r1192625520
##########
gremlin-console/src/main/static/licenses/asm:
##########
@@ -0,0 +1,27 @@
+ASM: a very small and fast Java bytecode manipulation framework
Review Comment:
Sure, I wasn't aware that inclusion in groovy was sufficient. I will remove ASM from the licenses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on a diff in pull request #2063: 3.6: fixing licenses/NOTICE for console and server distributions
Posted by "spmallette (via GitHub)" <gi...@apache.org>.
spmallette commented on code in PR #2063:
URL: https://github.com/apache/tinkerpop/pull/2063#discussion_r1192615914
##########
gremlin-console/src/main/static/LICENSE:
##########
@@ -216,6 +216,10 @@ The Apache TinkerPop project bundles the following components under the BSD Lice
minlog (com.esotericsoftware:minlog:1.3.0 - https://github.com/EsotericSoftware/minlog)
- shaded in gremlin-shaded to org.apache.tinkerpop.shaded.minlog
- for details, see licenses/minlog
+ Antlr4 (org.antlr:antlr4-runtime:4.9.1 - https://www.antlr.org) - for details, see licenses/antlr4
Review Comment:
the groovy jar LICENSE already references ANTLR (not the detail level we do, but i suppose that is their style). i don't think we need to do it again. it just complicates our LICENSE. simply including
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on a diff in pull request #2063: 3.6: fixing licenses/NOTICE for console and server distributions
Posted by "spmallette (via GitHub)" <gi...@apache.org>.
spmallette commented on code in PR #2063:
URL: https://github.com/apache/tinkerpop/pull/2063#discussion_r1192639840
##########
gremlin-console/src/main/static/LICENSE:
##########
@@ -216,6 +216,10 @@ The Apache TinkerPop project bundles the following components under the BSD Lice
minlog (com.esotericsoftware:minlog:1.3.0 - https://github.com/EsotericSoftware/minlog)
- shaded in gremlin-shaded to org.apache.tinkerpop.shaded.minlog
- for details, see licenses/minlog
+ Antlr4 (org.antlr:antlr4-runtime:4.9.1 - https://www.antlr.org) - for details, see licenses/antlr4
Review Comment:
oh...ok. then yeah for antlr then.
for asm i think a less complicated NOTICE beats the buried one, but this is all an art. i tried to write "rules" as best i could in all my learnings from the ASF on how to do this, but i wouldn't say my "rules" are hard and fast.
if you really want to dig into it, you could try to get an answer from the ASF. i'd guess the incubator would be the best place to ask this question. be prepared for 10 different answers though 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer commented on a diff in pull request #2063: 3.6: fixing licenses/NOTICE for console and server distributions
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on code in PR #2063:
URL: https://github.com/apache/tinkerpop/pull/2063#discussion_r1192623474
##########
gremlin-console/src/main/static/LICENSE:
##########
@@ -216,6 +216,10 @@ The Apache TinkerPop project bundles the following components under the BSD Lice
minlog (com.esotericsoftware:minlog:1.3.0 - https://github.com/EsotericSoftware/minlog)
- shaded in gremlin-shaded to org.apache.tinkerpop.shaded.minlog
- for details, see licenses/minlog
+ Antlr4 (org.antlr:antlr4-runtime:4.9.1 - https://www.antlr.org) - for details, see licenses/antlr4
Review Comment:
I'm certainly not an expert in this domain but my understanding was that for any dependency, including transitive ones, if any binary/source is packaged within our distribution then we need to meet any NOTICE/license obligations at the root level. If it is acceptable for those to be buried within the jar that contains the transitive dependency then ASM can definitely be removed here.
On the other hand the ANTLR jar is directly included in lib directory in both the console and server distributions. In this case I don't think the license buried within the groovy jar is good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #2063: 3.6: fixing licenses/NOTICE for console and server distributions
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2063:
URL: https://github.com/apache/tinkerpop/pull/2063#issuecomment-1544948607
## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2063?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2063](https://app.codecov.io/gh/apache/tinkerpop/pull/2063?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (95510a9) into [3.6-dev](https://app.codecov.io/gh/apache/tinkerpop/commit/4b51fd24075a3ef2ba044cc01670378bce9feafa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4b51fd2) will **decrease** coverage by `4.95%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.6-dev #2063 +/- ##
=============================================
- Coverage 69.54% 64.59% -4.95%
=============================================
Files 878 25 -853
Lines 42283 3802 -38481
Branches 5655 0 -5655
=============================================
- Hits 29406 2456 -26950
+ Misses 10888 1179 -9709
+ Partials 1989 167 -1822
```
[see 853 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2063/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy merged pull request #2063: 3.6: fixing licenses/NOTICE for console and server distributions
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy merged PR #2063:
URL: https://github.com/apache/tinkerpop/pull/2063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on a diff in pull request #2063: 3.6: fixing licenses/NOTICE for console and server distributions
Posted by "spmallette (via GitHub)" <gi...@apache.org>.
spmallette commented on code in PR #2063:
URL: https://github.com/apache/tinkerpop/pull/2063#discussion_r1192615914
##########
gremlin-console/src/main/static/LICENSE:
##########
@@ -216,6 +216,10 @@ The Apache TinkerPop project bundles the following components under the BSD Lice
minlog (com.esotericsoftware:minlog:1.3.0 - https://github.com/EsotericSoftware/minlog)
- shaded in gremlin-shaded to org.apache.tinkerpop.shaded.minlog
- for details, see licenses/minlog
+ Antlr4 (org.antlr:antlr4-runtime:4.9.1 - https://www.antlr.org) - for details, see licenses/antlr4
Review Comment:
the groovy jar LICENSE already references ANTLR/asm (not the detail level we do, but i suppose that is their style). i don't think we need to do it again. it just complicates our LICENSE. simply including
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on a diff in pull request #2063: 3.6: fixing licenses/NOTICE for console and server distributions
Posted by "spmallette (via GitHub)" <gi...@apache.org>.
spmallette commented on code in PR #2063:
URL: https://github.com/apache/tinkerpop/pull/2063#discussion_r1192617817
##########
gremlin-console/src/main/static/licenses/asm:
##########
@@ -0,0 +1,27 @@
+ASM: a very small and fast Java bytecode manipulation framework
Review Comment:
already in the groovy jar. i dont' think we need to include it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy commented on pull request #2063: 3.6: fixing licenses/NOTICE for console and server distributions
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #2063:
URL: https://github.com/apache/tinkerpop/pull/2063#issuecomment-1546158070
Thanks Cole! VOTE +1, merging as CTR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on a diff in pull request #2063: 3.6: fixing licenses/NOTICE for console and server distributions
Posted by "spmallette (via GitHub)" <gi...@apache.org>.
spmallette commented on code in PR #2063:
URL: https://github.com/apache/tinkerpop/pull/2063#discussion_r1192629554
##########
gremlin-server/src/main/static/NOTICE:
##########
@@ -64,3 +64,29 @@ HPPC borrowed code, ideas or both from:
Netty 4.1.86
------------------------------------------------------------------------
Copyright 2014 The Netty Project
+
+------------------------------------------------------------------------
+Objenesis 2.4 (Included through gremlin-shaded)
+------------------------------------------------------------------------
+Copyright 2006-2016 Joe Walnes, Henri Tremblay, Leonardo Mesquita
+
+------------------------------------------------------------------------
+Jackson-Databind 2.14.0 and Jackson-Core (Included through gremlin-shaded)
Review Comment:
eh....i dunno about this NOTICE for jackson. the rule is to reproduce the NOTICE here as-is so you did that, but i'm not sure this NOTICE really says anything and just makes ours more complex which isn't desireable. Take a look at what we do for netty then take a look at their NOTICE file. we basically took one line and threw away 100+. i think the same abbreviation might be relevant in this case. let's simplify to:
> Written by Tatu Saloranta (tatu.saloranta@iki.fi), and has been in development since 2007.
I sense everything else is obvious and I don't think there is a need to include the CREDITS file. I'm not so sure we even need to include the above bit, but let's do it.
Finally, note that these items were meant to be kept alphabetically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer commented on a diff in pull request #2063: 3.6: fixing licenses/NOTICE for console and server distributions
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on code in PR #2063:
URL: https://github.com/apache/tinkerpop/pull/2063#discussion_r1192663921
##########
gremlin-console/src/main/static/LICENSE:
##########
@@ -216,6 +216,10 @@ The Apache TinkerPop project bundles the following components under the BSD Lice
minlog (com.esotericsoftware:minlog:1.3.0 - https://github.com/EsotericSoftware/minlog)
- shaded in gremlin-shaded to org.apache.tinkerpop.shaded.minlog
- for details, see licenses/minlog
+ Antlr4 (org.antlr:antlr4-runtime:4.9.1 - https://www.antlr.org) - for details, see licenses/antlr4
Review Comment:
I have removed ASM licenses as they are properly covered by groovy. The BSD requirements are that redistributions must reproduce the license and it is definitely reproduced within the groovy jar. This argument could be extended to remove kryo and minilog from the console and server licenses as this PR is adding proper licensing for them within the gremlin-shaded jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on a diff in pull request #2063: 3.6: fixing licenses/NOTICE for console and server distributions
Posted by "spmallette (via GitHub)" <gi...@apache.org>.
spmallette commented on code in PR #2063:
URL: https://github.com/apache/tinkerpop/pull/2063#discussion_r1192617592
##########
gremlin-console/src/main/static/licenses/antlr4:
##########
@@ -0,0 +1,28 @@
+Copyright (c) 2012-2022 The ANTLR Project. All rights reserved.
Review Comment:
already in the groovy jar. i don't think we need to include it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org