You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/01/04 13:21:05 UTC

[GitHub] [calcite] rubenada opened a new pull request #2313: [CALCITE-4453] RexExecutorImpl#compile should use RexBuilder's type factory if possible

rubenada opened a new pull request #2313:
URL: https://github.com/apache/calcite/pull/2313


   Jira: [CALCITE-4453](https://issues.apache.org/jira/browse/CALCITE-4453)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] rubenada merged pull request #2313: [CALCITE-4453] RexExecutorImpl#compile should use RexBuilder's type factory if possible

Posted by GitBox <gi...@apache.org>.
rubenada merged pull request #2313:
URL: https://github.com/apache/calcite/pull/2313


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] rubenada commented on pull request #2313: [CALCITE-4453] RexExecutorImpl#compile should use RexBuilder's type factory if possible

Posted by GitBox <gi...@apache.org>.
rubenada commented on pull request #2313:
URL: https://github.com/apache/calcite/pull/2313#issuecomment-754630557


   Thanks for the review @vlsi . I have applied your suggestion.
   I will merge the PR in the next 24h if nobody presents any objection.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] vlsi commented on pull request #2313: [CALCITE-4453] RexExecutorImpl#compile should use RexBuilder's type factory if possible

Posted by GitBox <gi...@apache.org>.
vlsi commented on pull request #2313:
URL: https://github.com/apache/calcite/pull/2313#issuecomment-754616056


   Looks good to me, however `rexBuilder.getTypeFactory()` might be de-duplicated to its own variable.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] amaliujia commented on pull request #2313: [CALCITE-4453] RexExecutorImpl#compile should use RexBuilder's type factory if possible

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #2313:
URL: https://github.com/apache/calcite/pull/2313#issuecomment-755000600


   Also LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org