You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yuluo-yx (via GitHub)" <gi...@apache.org> on 2026/08/20 15:57:08 UTC

[PR] [ISSUE #2442] fix(aliyun): paginate all consumer groups [rocketmq-dashboard]

yuluo-yx opened a new pull request, #2449:
URL: https://github.com/apache/rocketmq-dashboard/pull/2449

   ## Summary
   
   - remove the fixed five-page limit from Aliyun consumer group listing
   - stop when totalCount is reached or a short page is returned
   - cover a final group returned on page six
   
   ## Verification
   
   - AliyunInstanceProviderTest: 23 tests passed
   - Maven Checkstyle: 0 violations
   - scope check: 31 changed lines
   
   Fixes #2442


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE #2442] fix(aliyun): paginate all consumer groups [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #2449: [ISSUE #2442] fix(aliyun): paginate all consumer groups
URL: https://github.com/apache/rocketmq-dashboard/pull/2449


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE #2442] fix(aliyun): paginate all consumer groups [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #2449:
URL: https://github.com/apache/rocketmq-dashboard/pull/2449#issuecomment-5434898190

   Thanks for the fixes — they were reviewed individually and most look good. However, for this many small single-commit changes we prefer contributors to consolidate related fixes into a few cohesive pull requests following the contribution guidelines, instead of submitting them separately.
   
   Closing for now. Please regroup these changes by functional area (e.g. backend normalization, Aliyun provider, frontend components, frontend data/config, deploy scripts) into a small number of PRs and resubmit — the individual commits reviewed here can be reused as-is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org