You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/11/04 16:16:23 UTC

[GitHub] [iotdb] JesseZhou-1 opened a new pull request #1944: [IOTDB-974] Convert tables from HTML language to markdown grammar in all md files

JesseZhou-1 opened a new pull request #1944:
URL: https://github.com/apache/iotdb/pull/1944


   I rewrote most of the tables from HTML language to markdown grammar, and used figures to represent the complex ones. If there is any table in HTML language that I missed, please let me know. I will make sure to convert them afterward.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] JesseZhou-1 commented on pull request #1944: [IOTDB-974] Convert tables from HTML language to markdown grammar in all md files

Posted by GitBox <gi...@apache.org>.
JesseZhou-1 commented on pull request #1944:
URL: https://github.com/apache/iotdb/pull/1944#issuecomment-722097277


   @jixuan1989 Done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] jixuan1989 commented on a change in pull request #1944: [IOTDB-974] Convert tables from HTML language to markdown grammar in all md files

Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #1944:
URL: https://github.com/apache/iotdb/pull/1944#discussion_r517778065



##########
File path: docs/UserGuide/Ecosystem Integration/MapReduce TsFile.md
##########
@@ -46,7 +46,7 @@ With this connector, you can
 ## System Requirements
 
 |Hadoop Version | Java Version | TsFile Version|
-|-------------  | ------------ |------------ |
+|:------------- : | :------------ :|:------------: |

Review comment:
       something error here.
   maybe we need "blank" between ":" and "|"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] JesseZhou-1 commented on a change in pull request #1944: [IOTDB-974] Convert tables from HTML language to markdown grammar in all md files

Posted by GitBox <gi...@apache.org>.
JesseZhou-1 commented on a change in pull request #1944:
URL: https://github.com/apache/iotdb/pull/1944#discussion_r517781955



##########
File path: docs/UserGuide/Ecosystem Integration/MapReduce TsFile.md
##########
@@ -46,7 +46,7 @@ With this connector, you can
 ## System Requirements
 
 |Hadoop Version | Java Version | TsFile Version|
-|-------------  | ------------ |------------ |
+|:------------- : | :------------ :|:------------: |

Review comment:
       solved




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] JesseZhou-1 commented on pull request #1944: [IOTDB-974] Convert tables from HTML language to markdown grammar in all md files

Posted by GitBox <gi...@apache.org>.
JesseZhou-1 commented on pull request #1944:
URL: https://github.com/apache/iotdb/pull/1944#issuecomment-722135710


   update all png files, all columns now have the exact same width.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] jixuan1989 commented on pull request #1944: [IOTDB-974] Convert tables from HTML language to markdown grammar in all md files

Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #1944:
URL: https://github.com/apache/iotdb/pull/1944#issuecomment-722056764


   Thanks @JesseZhou-1 . As the master branch merged a PR yesterday and the Memory Estimation Tool.md is deleted in that PR, you have to solve the conflict (just remove the file).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] qiaojialin merged pull request #1944: [IOTDB-974] Convert tables from HTML language to markdown grammar in all md files

Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #1944:
URL: https://github.com/apache/iotdb/pull/1944


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org