You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2016/11/03 18:05:50 UTC
[GitHub] storm pull request #1761: STORM-2184: Don't wakeup KafkaConsumer on shutdown...
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/1761
STORM-2184: Don't wakeup KafkaConsumer on shutdown, spout methods are\u2026
... not called by multiple threads at a time
See https://issues.apache.org/jira/browse/STORM-2184
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-2184
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1761.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1761
----
commit ac4f0404590eda08308c7698f1ada9963563f6a6
Author: Stig Rohde D�ssing <sd...@it-minds.dk>
Date: 2016-11-02T17:36:44Z
STORM-2184: Don't wakeup KafkaConsumer on shutdown, spout methods are not called by multiple threads at a time
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1761: STORM-2184: Don't wakeup KafkaConsumer on shutdown, spout...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1761
+1 The discussion on STORM-2184 makes since that wakeup seems to not be needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1761: STORM-2184: Don't wakeup KafkaConsumer on shutdown, spout...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1761
+1 KafkaConsumer seems to be initialized for each task (so used from only one thread), and so as ConsumerNetworkClient in KafkaConsumer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1761: STORM-2184: Don't wakeup KafkaConsumer on shutdown...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1761
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---