[jira] [Closed] (PROTON-813) Pulling latest version of ws WebSocket library from npm central breaks JavaScript bindings.

["Fraser Adams (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PROTON-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fraser Adams closed PROTON-813.
-------------------------------

> Pulling latest version of ws WebSocket library from npm central breaks JavaScript bindings.
> -------------------------------------------------------------------------------------------
>
>                 Key: PROTON-813
>                 URL: https://issues.apache.org/jira/browse/PROTON-813
>             Project: Qpid Proton
>          Issue Type: Bug
>            Reporter: Fraser Adams
>            Assignee: Fraser Adams
>            Priority: Blocker
>
> It looks like some change in the ws WebSocket library in npm central has broken something. From what I've been able to ascertain it was the change between 0.5.0 and 0.6.0 where the issue lies (sometime around 5th December by the looks of it).
> TBH I probably should have been a bit more explicit with versions of dependencies, but I'm kind of learning with npm and rather making up as I go but I've now pushed a change to trunk https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git that pins the ws version to 0.5.0 for now.
> If you get bitten by this and don't want to update to the latest proton in trunk just yet it's fairly easy to sort out, the following should do the trick:
> cd <proton-root>
> rm -rf node_modules/ws
> npm install ws@0.5.0
> It'll clearly be good to work out what has actually changed, but I'll need a bit of quality time to do more digging, it might be something in the binding code, but it *could* be something in the emscripten network code that has been borked, for now pinning the ws version seems the best approach. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)