[GitHub] [incubator-opendal] messense commented on a diff in pull request #1729: feat(bindings/python): convert to mixed Python/Rust project layout

["messense (via GitHub)" <gi...@apache.org>]

messense commented on code in PR #1729:
URL: https://github.com/apache/incubator-opendal/pull/1729#discussion_r1144192059


##########
bindings/python/Cargo.toml:
##########
@@ -28,7 +28,7 @@ version = "0.30.3"
 [lib]
 crate-type = ["cdylib"]
 doc = false
-name = "opendal"
+name = "_opendal"

Review Comment:
   It's the common practice in Python ecosystem.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org