You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2014/04/10 18:25:21 UTC

Review Request 20220: Remove hard coded Service, Component mapping from LiveStatus.py

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20220/
-----------------------------------------------------------

Review request for Ambari and Sid Wagle.


Bugs: AMBARI-5423
    https://issues.apache.org/jira/browse/AMBARI-5423


Repository: ambari


Description
-------

ambari_agent/LiveStatus.py:
The stacks API should be able to provide the available Service / Component mappings needed.

Agent gets service-component mapping for current stack by making /agent/components API call. 


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/Controller.py ad928c2 
  ambari-agent/src/main/python/ambari_agent/LiveStatus.py 01b6c2b 
  ambari-agent/src/test/python/ambari_agent/TestActualConfigHandler.py ae66ead 
  ambari-agent/src/test/python/ambari_agent/TestController.py 1e7c868 
  ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py 345bd44 
  ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentsResponse.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java d9c211a 
  ambari-server/src/main/java/org/apache/ambari/server/agent/rest/AgentResource.java 9037162 
  ambari-server/src/test/java/org/apache/ambari/server/agent/AgentResourceTest.java 3c663fa 
  ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java a1f4886 

Diff: https://reviews.apache.org/r/20220/diff/


Testing
-------

[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ....................................... SUCCESS [1.584s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.236s]
[INFO] Ambari Web ........................................ SUCCESS [10.268s]
[INFO] Ambari Views ...................................... SUCCESS [1.297s]
[INFO] Ambari Server ..................................... SUCCESS [12:18.160s]
[INFO] Ambari Agent ...................................... SUCCESS [36.275s]
[INFO] Ambari Client ..................................... SUCCESS [0.745s]
[INFO] ------------------------------------------------------------------------


Thanks,

Dmytro Sen


Re: Review Request 20220: Remove hard coded Service, Component mapping from LiveStatus.py

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20220/#review40038
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On April 10, 2014, 4:25 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20220/
> -----------------------------------------------------------
> 
> (Updated April 10, 2014, 4:25 p.m.)
> 
> 
> Review request for Ambari and Sid Wagle.
> 
> 
> Bugs: AMBARI-5423
>     https://issues.apache.org/jira/browse/AMBARI-5423
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> ambari_agent/LiveStatus.py:
> The stacks API should be able to provide the available Service / Component mappings needed.
> 
> Agent gets service-component mapping for current stack by making /agent/components API call. 
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Controller.py ad928c2 
>   ambari-agent/src/main/python/ambari_agent/LiveStatus.py 01b6c2b 
>   ambari-agent/src/test/python/ambari_agent/TestActualConfigHandler.py ae66ead 
>   ambari-agent/src/test/python/ambari_agent/TestController.py 1e7c868 
>   ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py 345bd44 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentsResponse.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java d9c211a 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/rest/AgentResource.java 9037162 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/AgentResourceTest.java 3c663fa 
>   ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java a1f4886 
> 
> Diff: https://reviews.apache.org/r/20220/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [1.584s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.236s]
> [INFO] Ambari Web ........................................ SUCCESS [10.268s]
> [INFO] Ambari Views ...................................... SUCCESS [1.297s]
> [INFO] Ambari Server ..................................... SUCCESS [12:18.160s]
> [INFO] Ambari Agent ...................................... SUCCESS [36.275s]
> [INFO] Ambari Client ..................................... SUCCESS [0.745s]
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>