You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/11 00:09:49 UTC

[GitHub] [pulsar] k2la opened a new issue #8030: enableReplicatedSubscriptions is not used.

k2la opened a new issue #8030:
URL: https://github.com/apache/pulsar/issues/8030


   It seems that "replicated subscriptions" is always enabled because `enableReplicatedSubscriptions` is not used.
   - https://github.com/apache/pulsar/search?q=enableReplicatedSubscriptions&unscoped_q=enableReplicatedSubscriptions
   - https://github.com/apache/pulsar/blob/22b8923a251c3356401090dacb8ff97fd37d14c1/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java#L688


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] k2la edited a comment on issue #8030: enableReplicatedSubscriptions is not used.

Posted by GitBox <gi...@apache.org>.

k2la edited a comment on issue #8030:
URL: https://github.com/apache/pulsar/issues/8030#issuecomment-693996165

Is the behavior decided when Replicated Subscriptions is OFF ?
I think the behavior is as the following in the case:
- Brokers send `NotAllowedException` to consumers that subscribe with Replicated Subscriptions.
- Replicators don't send marker messages and deal with them.

I will try to implement the above behavior by the following ways.
Please let me know if there are any problems.

#### Brokers send `NotAllowedException` to consumers that subscribe with Replicated Subscriptions.
Like Key_Shared, send `NotAllowedException` in `PersistentTopics#subscribe`:
https://github.com/apache/pulsar/blob/v2.6.1/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L533-L539

#### Replicators don't send marker messages and deal with them.
Broker does not create `ReplicatedSubscriptionsController` instance that sends marker messages.
Fix if statement in order to set `ReplicatedSubscriptionsController` instance `Optional.empty()`:
https://github.com/apache/pulsar/blob/v2.6.1/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L2158-L2162

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] k2la edited a comment on issue #8030: enableReplicatedSubscriptions is not used.

Posted by GitBox <gi...@apache.org>.

k2la edited a comment on issue #8030:
URL: https://github.com/apache/pulsar/issues/8030#issuecomment-693996165

Is the behavior decided when Replicated Subscriptions is OFF ?
I think the behavior is as the following in the case:
- Brokers send `NotAllowedException` to consumers that subscribe with replicated subccription.
- Replicators don't send marker messages and deal with them.

I will try to implement the above behavior by the following ways.
Please let me know if there are any problems.

#### Brokers send `NotAllowedException` to consumers that subscribe with replicated subccription.
Like Key_Shared, send `NotAllowedException` in `PersistentTopics#subscribe`:
https://github.com/apache/pulsar/blob/v2.6.1/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L533-L539

#### Replicators don't send marker messages and deal with them.
Broker do not create `ReplicatedSubscriptionsController` instance that sends marker messages.
Fix if statement in order to set `ReplicatedSubscriptionsController` instance `Optional.empty()`:
https://github.com/apache/pulsar/blob/v2.6.1/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L2158-L2162

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie closed issue #8030: enableReplicatedSubscriptions is not used.

Posted by GitBox <gi...@apache.org>.

sijie closed issue #8030:
URL: https://github.com/apache/pulsar/issues/8030


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] k2la commented on issue #8030: enableReplicatedSubscriptions is not used.

Posted by GitBox <gi...@apache.org>.

k2la commented on issue #8030:
URL: https://github.com/apache/pulsar/issues/8030#issuecomment-693996165

Is the behavior decided when Replicated Subscriptions is OFF ?
I think the behavior is as the following in the case:
- Brokers send `NotAllowedException` to consumers that subscribe with replicated subccription.
- Replicators don't send marker messages and deal with them.

I will try to implement the above behavior by the following ways.
Please let me know if there are any problems.

#### Replicators don't send marker messages and deal with them.
Broker do not create `ReplicatedSubscriptionsController` instance that sends marker messages.
Fix to enter the following if statement:
https://github.com/apache/pulsar/blob/v2.6.1/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L2158-L2162

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on issue #8030: enableReplicatedSubscriptions is not used.

Posted by GitBox <gi...@apache.org>.

sijie commented on issue #8030:
URL: https://github.com/apache/pulsar/issues/8030#issuecomment-701906573


   It is fixed by #8144 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org