You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "beyond1920 (via GitHub)" <gi...@apache.org> on 2023/03/17 13:17:08 UTC
[GitHub] [hudi] beyond1920 opened a new pull request, #8218: [HUDI-5879] Extends evaluators to support evaluate based on column values
beyond1920 opened a new pull request, #8218:
URL: https://github.com/apache/hudi/pull/8218
### Change Logs
The pr aims to extends evaluators to support evaluate based on column value. It could be wrapped in a `ColumnStats` object, which min is same with max and nullCnt is 0.
### Impact
NA
### Risk level (write none, low medium or high below)
NA
### Documentation Update
NA
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8218: [HUDI-5879] Extends evaluators to support evaluate based on column values
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8218:
URL: https://github.com/apache/hudi/pull/8218#issuecomment-1474840391
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b2db2061014b8f7802e73876c7f96230333c2022",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15770",
"triggerID" : "b2db2061014b8f7802e73876c7f96230333c2022",
"triggerType" : "PUSH"
}, {
"hash" : "57f74b995ba11d91cefcfe87fc17c183dddb15e3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15782",
"triggerID" : "57f74b995ba11d91cefcfe87fc17c183dddb15e3",
"triggerType" : "PUSH"
}, {
"hash" : "bf0be217049578df0e11df710595d14702bd74bb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15783",
"triggerID" : "bf0be217049578df0e11df710595d14702bd74bb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 57f74b995ba11d91cefcfe87fc17c183dddb15e3 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15782)
* bf0be217049578df0e11df710595d14702bd74bb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15783)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8218: [HUDI-5879] Extends evaluators to support evaluate based on column values
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8218:
URL: https://github.com/apache/hudi/pull/8218#issuecomment-1473874774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b2db2061014b8f7802e73876c7f96230333c2022",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b2db2061014b8f7802e73876c7f96230333c2022",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b2db2061014b8f7802e73876c7f96230333c2022 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8218: [HUDI-5879] Extends evaluators to support evaluate based on column values
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8218:
URL: https://github.com/apache/hudi/pull/8218#issuecomment-1474829571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b2db2061014b8f7802e73876c7f96230333c2022",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15770",
"triggerID" : "b2db2061014b8f7802e73876c7f96230333c2022",
"triggerType" : "PUSH"
}, {
"hash" : "57f74b995ba11d91cefcfe87fc17c183dddb15e3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15782",
"triggerID" : "57f74b995ba11d91cefcfe87fc17c183dddb15e3",
"triggerType" : "PUSH"
}, {
"hash" : "bf0be217049578df0e11df710595d14702bd74bb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bf0be217049578df0e11df710595d14702bd74bb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 57f74b995ba11d91cefcfe87fc17c183dddb15e3 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15782)
* bf0be217049578df0e11df710595d14702bd74bb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8218: [HUDI-5879] Extends evaluators to support evaluate based on column values
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8218:
URL: https://github.com/apache/hudi/pull/8218#discussion_r1140250519
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/ExpressionEvaluators.java:
##########
@@ -255,9 +255,12 @@ public static NotEqualTo getInstance() {
@Override
protected boolean eval(@NotNull Object val, ColumnStats columnStats, LogicalType type) {
- // because the bounds are not necessarily a min or max value, this cannot be answered using them.
- // notEq(col, X) with (X, Y) doesn't guarantee that X is a value in col.
- return true;
Review Comment:
Suggest to keep this comment and add specific explanation for constant column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8218: [HUDI-5879] Extends evaluators to support evaluate based on column values
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8218:
URL: https://github.com/apache/hudi/pull/8218#issuecomment-1474820463
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b2db2061014b8f7802e73876c7f96230333c2022",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15770",
"triggerID" : "b2db2061014b8f7802e73876c7f96230333c2022",
"triggerType" : "PUSH"
}, {
"hash" : "57f74b995ba11d91cefcfe87fc17c183dddb15e3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15782",
"triggerID" : "57f74b995ba11d91cefcfe87fc17c183dddb15e3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 57f74b995ba11d91cefcfe87fc17c183dddb15e3 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15782)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8218: [HUDI-5879] Extends evaluators to support evaluate based on column values
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8218:
URL: https://github.com/apache/hudi/pull/8218#issuecomment-1474781086
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b2db2061014b8f7802e73876c7f96230333c2022",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15770",
"triggerID" : "b2db2061014b8f7802e73876c7f96230333c2022",
"triggerType" : "PUSH"
}, {
"hash" : "57f74b995ba11d91cefcfe87fc17c183dddb15e3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "57f74b995ba11d91cefcfe87fc17c183dddb15e3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b2db2061014b8f7802e73876c7f96230333c2022 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15770)
* 57f74b995ba11d91cefcfe87fc17c183dddb15e3 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8218: [HUDI-5879] Extends evaluators to support evaluate based on column values
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8218:
URL: https://github.com/apache/hudi/pull/8218#issuecomment-1473885990
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b2db2061014b8f7802e73876c7f96230333c2022",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15770",
"triggerID" : "b2db2061014b8f7802e73876c7f96230333c2022",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b2db2061014b8f7802e73876c7f96230333c2022 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15770)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8218: [HUDI-5879] Extends evaluators to support evaluate based on column values
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8218:
URL: https://github.com/apache/hudi/pull/8218#issuecomment-1474789984
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b2db2061014b8f7802e73876c7f96230333c2022",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15770",
"triggerID" : "b2db2061014b8f7802e73876c7f96230333c2022",
"triggerType" : "PUSH"
}, {
"hash" : "57f74b995ba11d91cefcfe87fc17c183dddb15e3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15782",
"triggerID" : "57f74b995ba11d91cefcfe87fc17c183dddb15e3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b2db2061014b8f7802e73876c7f96230333c2022 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15770)
* 57f74b995ba11d91cefcfe87fc17c183dddb15e3 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15782)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8218: [HUDI-5879] Extends evaluators to support evaluate based on column values
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8218:
URL: https://github.com/apache/hudi/pull/8218#issuecomment-1474859767
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b2db2061014b8f7802e73876c7f96230333c2022",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15770",
"triggerID" : "b2db2061014b8f7802e73876c7f96230333c2022",
"triggerType" : "PUSH"
}, {
"hash" : "57f74b995ba11d91cefcfe87fc17c183dddb15e3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15782",
"triggerID" : "57f74b995ba11d91cefcfe87fc17c183dddb15e3",
"triggerType" : "PUSH"
}, {
"hash" : "bf0be217049578df0e11df710595d14702bd74bb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15783",
"triggerID" : "bf0be217049578df0e11df710595d14702bd74bb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bf0be217049578df0e11df710595d14702bd74bb Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15783)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8218: [HUDI-5879] Extends evaluators to support evaluate based on column values
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8218:
URL: https://github.com/apache/hudi/pull/8218#issuecomment-1474103127
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b2db2061014b8f7802e73876c7f96230333c2022",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15770",
"triggerID" : "b2db2061014b8f7802e73876c7f96230333c2022",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b2db2061014b8f7802e73876c7f96230333c2022 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15770)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #8218: [HUDI-5879] Extends evaluators to support evaluate based on column values
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #8218:
URL: https://github.com/apache/hudi/pull/8218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org