You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/16 06:04:17 UTC

[GitHub] [spark] sarutak commented on a change in pull request #35838: [MINOR][INFRA] Add ANTLR generated files to .gitignore

sarutak commented on a change in pull request #35838:
URL: https://github.com/apache/spark/pull/35838#discussion_r827654849



##########
File path: .gitignore
##########
@@ -117,3 +117,7 @@ spark-warehouse/
 
 # For Node.js
 node_modules
+
+# For Antlr
+sql/catalyst/gen/
+*.tokens

Review comment:
       All the entries we need to add are:
   ```
   sql/catalyst/gen/
   sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/gen/
   ```
   right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org