You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/09/06 13:14:46 UTC
[GitHub] [solr] cpoerschke opened a new pull request #285: SOLR-15619: add Long support for @JsonProperty annotations
cpoerschke opened a new pull request #285:
URL: https://github.com/apache/solr/pull/285
https://issues.apache.org/jira/browse/SOLR-15619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on pull request #285: SOLR-15619: add Long support for @JsonProperty annotations
Posted by GitBox <gi...@apache.org>.
gerlowskija commented on pull request #285:
URL: https://github.com/apache/solr/pull/285#issuecomment-946661342
I don't want to preempt a review from someone with more context like Jan or Gus, but this lgtm from the little context I've got.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on pull request #285: SOLR-15619: add Long support for @JsonProperty annotations
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #285:
URL: https://github.com/apache/solr/pull/285#issuecomment-942078818
Via @bitnahian's changes in #202 there is a TRA (Time Routed Alias) connection of sorts here.
@gus-asf and/or @janhoy perhaps you would be interested in reviewing the changes in this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on pull request #285: SOLR-15619: add Long support for @JsonProperty annotations
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #285:
URL: https://github.com/apache/solr/pull/285#issuecomment-970077080
Re-ran the new tests and also the full test suite locally, it all passed.
Proceeding to merge. As always, happy to action any post commit code review feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke merged pull request #285: SOLR-15619: add Long support for @JsonProperty annotations
Posted by GitBox <gi...@apache.org>.
cpoerschke merged pull request #285:
URL: https://github.com/apache/solr/pull/285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on pull request #285: SOLR-15619: add Long support for @JsonProperty annotations
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #285:
URL: https://github.com/apache/solr/pull/285#issuecomment-942078818
Via @bitnahian's changes in #202 there is a TRA (Time Routed Alias) connection of sorts here.
@gus-asf and/or @janhoy perhaps you would be interested in reviewing the changes in this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org