[GitHub] [superset] betodealmeida commented on a diff in pull request #19890: chore: upgrade SQLAlchemy

[GitBox <gi...@apache.org>]

betodealmeida commented on code in PR #19890:
URL: https://github.com/apache/superset/pull/19890#discussion_r864263699


##########
tests/integration_tests/config_tests.py:
##########
@@ -137,6 +137,9 @@ def test_python_date_format_by_column_name(self):
         self.assertEqual(dms_col.python_date_format, "invalid")
 
     def test_expression_by_column_name(self):

Review Comment:
   I was not able to reproduce the failing SQLite tests no matter what — I even tried https://github.com/nektos/act and running the containers manually. So I rewrote them as proper unit tests. :-P



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org