[GitHub] [netbeans] tmysik commented on a change in pull request #1301: [NETBEANS-1696] PHP 7.4 Support: Typed Properties 2.0

[GitBox <gi...@apache.org>]

tmysik commented on a change in pull request #1301: [NETBEANS-1696] PHP 7.4 Support: Typed Properties 2.0
URL: https://github.com/apache/netbeans/pull/1301#discussion_r294159193
 
 

 ##########
 File path: php/php.editor/src/org/netbeans/modules/php/editor/completion/PHPCodeCompletion.java
 ##########
 @@ -1073,7 +1061,61 @@ private void autoCompleteInClassContext(
                     }
                 }
             }
+        } else if (completeFieldTypes(tokenSequence, caretOffset, th, info.getSnapshot().getSource().getFileObject())){
+            autoCompleteFieldType(completionResult, request);
+        }
+    }
+
+    private void autoCompleteFieldType(final PHPCompletionResult completionResult, CompletionRequest request) {
+        // PHP 7.4 Typed Properties 2.0
 
 Review comment:
   Nitpick: maybe we could provide a link to the RFC directly here.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists