You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/12/30 20:39:54 UTC
svn commit: r1776636 - in
/jmeter/trunk/src/components/org/apache/jmeter/visualizers:
MailerVisualizer.java RenderAsXML.java
Author: pmouawad
Date: Fri Dec 30 20:39:54 2016
New Revision: 1776636
URL: http://svn.apache.org/viewvc?rev=1776636&view=rev
Log:
Sonar : Remove useless assignment
Modified:
jmeter/trunk/src/components/org/apache/jmeter/visualizers/MailerVisualizer.java
jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java
Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/MailerVisualizer.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/MailerVisualizer.java?rev=1776636&r1=1776635&r2=1776636&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/MailerVisualizer.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/MailerVisualizer.java Fri Dec 30 20:39:54 2016
@@ -421,13 +421,7 @@ public class MailerVisualizer extends Ab
* Shows a message using a DialogBox.
*/
private void displayMessage(String message, boolean isError) {
- int type = 0;
-
- if (isError) {
- type = JOptionPane.ERROR_MESSAGE;
- } else {
- type = JOptionPane.INFORMATION_MESSAGE;
- }
+ int type = isError ? JOptionPane.ERROR_MESSAGE : JOptionPane.INFORMATION_MESSAGE;
JOptionPane.showMessageDialog(null, message, isError ?
JMeterUtils.getResString("mailer_msg_title_error") : // $NON-NLS-1$
JMeterUtils.getResString("mailer_msg_title_information"), type); // $NON-NLS-1$
Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java?rev=1776636&r1=1776635&r2=1776636&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java Fri Dec 30 20:39:54 2016
@@ -73,12 +73,9 @@ public class RenderAsXML extends Sampler
}
}
- // there is also a javax.swing.text.Document class.
- org.w3c.dom.Document document = null;
-
StringWriter sw = new StringWriter();
Tidy tidy = XPathUtil.makeTidyParser(true, true, true, sw);
- document = tidy.parseDOM(baIS, null);
+ org.w3c.dom.Document document = tidy.parseDOM(baIS, null);
document.normalize();
if (tidy.getParseErrors() > 0) {
showErrorMessageDialog(sw.toString(),