You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Rancho-7 (via GitHub)" <gi...@apache.org> on 2025/03/13 03:04:56 UTC
[PR] add JDK 11 check and test [kafka]
Rancho-7 opened a new pull request, #19196:
URL: https://github.com/apache/kafka/pull/19196
Delete this text and replace it with a detailed description of your change. The
PR title and body will become the squashed commit message.
If you would like to tag individuals, add some commentary, upload images, or
include other supplemental information that should not be part of the eventual
commit message, please use a separate comment.
If applicable, please include a summary of the testing strategy (including
rationale) for the proposed change. Unit and/or integration tests are expected
for any behavior change and system tests should be considered for larger
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] KAFKA-18279: add JDK 11 check and test for clients and streams module [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19196:
URL: https://github.com/apache/kafka/pull/19196#issuecomment-3091474867
This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] KAFKA-18279: add JDK 11 check and test for clients and streams module [kafka]
Posted by "Rancho-7 (via GitHub)" <gi...@apache.org>.
Rancho-7 commented on PR #19196:
URL: https://github.com/apache/kafka/pull/19196#issuecomment-2719734796
I am getting this error while testing due to the `-Werror` flag in `build.gradle`,and I am working on fixing it.
```
> Task :streams:compileJava
/home/runner/work/kafka/kafka/streams/src/main/java/org/apache/kafka/streams/Topology.java:318: warning: [overloads] <K#1,V#1>addSource(AutoOffsetReset,String,Deserializer<K#1>,Deserializer<V#1>,String...) in Topology is potentially ambiguous with <K#2,V#2>addSource(AutoOffsetReset,String,TimestampExtractor,Deserializer<K#2>,Deserializer<V#2>,String...) in Topology
public synchronized <K, V> Topology addSource(final AutoOffsetReset offsetReset,
^
where K#1,V#1,K#2,V#2 are type-variables:
K#1 extends Object declared in method <K#1,V#1>addSource(AutoOffsetReset,String,Deserializer<K#1>,Deserializer<V#1>,String...)
V#1 extends Object declared in method <K#1,V#1>addSource(AutoOffsetReset,String,Deserializer<K#1>,Deserializer<V#1>,String...)
K#2 extends Object declared in method <K#2,V#2>addSource(AutoOffsetReset,String,TimestampExtractor,Deserializer<K#2>,Deserializer<V#2>,String...)
V#2 extends Object declared in method <K#2,V#2>addSource(AutoOffsetReset,String,TimestampExtractor,Deserializer<K#2>,Deserializer<V#2>,String...)
/home/runner/work/kafka/kafka/streams/src/main/java/org/apache/kafka/streams/Topology.java:330: warning: [overloads] <K#1,V#1>addSource(AutoOffsetReset,String,Deserializer<K#1>,Deserializer<V#1>,String...) in Topology is potentially ambiguous with <K#2,V#2>addSource(AutoOffsetReset,String,TimestampExtractor,Deserializer<K#2>,Deserializer<V#2>,String...) in Topology
public synchronized <K, V> Topology addSource(final org.apache.kafka.streams.AutoOffsetReset offsetReset,
^
where K#1,V#1,K#2,V#2 are type-variables:
K#1 extends Object declared in method <K#1,V#1>addSource(AutoOffsetReset,String,Deserializer<K#1>,Deserializer<V#1>,String...)
V#1 extends Object declared in method <K#1,V#1>addSource(AutoOffsetReset,String,Deserializer<K#1>,Deserializer<V#1>,String...)
K#2 extends Object declared in method <K#2,V#2>addSource(AutoOffsetReset,String,TimestampExtractor,Deserializer<K#2>,Deserializer<V#2>,String...)
V#2 extends Object declared in method <K#2,V#2>addSource(AutoOffsetReset,String,TimestampExtractor,Deserializer<K#2>,Deserializer<V#2>,String...)
error: warnings found and -Werror specified
1 error
2 warnings
> Task :streams:compileJava FAILED
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] KAFKA-18279: add JDK 11 check and test for clients and streams module [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19196:
URL: https://github.com/apache/kafka/pull/19196#issuecomment-2986503528
This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.
<p>
If you are having difficulty finding a reviewer, please reach out on the
[mailing list](https://kafka.apache.org/contact).
<p>
If this PR is no longer valid or desired, please feel free to close it. If no activity
occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] KAFKA-18279: add JDK 11 check and test for clients and streams module [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #19196: [WIP] KAFKA-18279: add JDK 11 check and test for clients and streams module
URL: https://github.com/apache/kafka/pull/19196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] KAFKA-18279: add JDK 11 check and test for clients and streams module [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #19196:
URL: https://github.com/apache/kafka/pull/19196#discussion_r2006272348
##########
.github/workflows/merge-check.yml:
##########
@@ -0,0 +1,264 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+name: Client and Streams Tests
+
+on:
+ push:
+ branches:
+ - trunk
+
+jobs:
+ test-modules:
+ runs-on: ubuntu-latest
+ strategy:
+ fail-fast: false
+ matrix:
+ java: [ 11 ]
+
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v4
+ with:
+ persist-credentials: false
+
+ - name: Set up JDK
+ uses: actions/setup-java@v4
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: temurin
+
+ - name: Setup Gradle
+ uses: ./.github/actions/setup-gradle
+ with:
+ java-version: ${{ matrix.java }}
+ develocity-access-key: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
+
+ - name: Run Tests
Review Comment:
That is a bit complicated. Maybe we can just run the check task as the main purpose is to ensure client/stream module is truly compatible to java 11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] KAFKA-18279: add JDK 11 check and test for clients and streams module [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19196:
URL: https://github.com/apache/kafka/pull/19196#issuecomment-2739024498
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] KAFKA-18279: add JDK 11 check and test for clients and streams module [kafka]
Posted by "Rancho-7 (via GitHub)" <gi...@apache.org>.
Rancho-7 commented on PR #19196:
URL: https://github.com/apache/kafka/pull/19196#issuecomment-2719723657
I found that our current test flow doesn't work with JDK 11 for the `clients` and `streams` modules. So I created a new test flow to handle this.
Here's what the output looks like:
<img width="837" alt="0313" src="https://github.com/user-attachments/assets/a75ef2ac-6576-48fb-81e2-32599fc20ff8" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org