[jira] [Commented] (MESOS-5354) Update "driver" as optional for DockerVolume.

["Jie Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-5354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304969#comment-15304969 ] 

Jie Yu commented on MESOS-5354:
-------------------------------

commit 183fb0431ceb185cd29ea34578415883c2db29cc
Author: Guangya Liu <gy...@gmail.com>
Date:   Fri May 27 16:08:34 2016 -0700

    Made "driver" as optional for DockerVolume.
    
    Review: https://reviews.apache.org/r/45377/

> Update "driver" as optional for DockerVolume.
> ---------------------------------------------
>
>                 Key: MESOS-5354
>                 URL: https://issues.apache.org/jira/browse/MESOS-5354
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Guangya Liu
>            Assignee: Guangya Liu
>            Priority: Blocker
>             Fix For: 0.29.0
>
>
> After some test with docker API, I found that when "docker run" to create a container, the volume name is required but volume driver is optional. When using "dvdcli", both name and driver are required. We are now defining the "driver" as required, we should update "driver" to optional so that the DockerContainerizer still works even if user did not specify driver when creating a container with volume.
> {code}
> message DockerVolume {
>       // Driver of the volume, it can be flocker, convoy, raxrey etc.
>       required string driver = 1;  <<<<<<<<<Update this to optional
>       // Name of the volume.
>       required string name = 2;
>       // Volume driver specific options.
>       optional Parameters driver_options = 3;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)