You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bigtop.apache.org by "Evans Ye (JIRA)" <ji...@apache.org> on 2016/02/07 18:09:39 UTC
[jira] [Comment Edited] (BIGTOP-2012) Add new tests for webhdfs
[ https://issues.apache.org/jira/browse/BIGTOP-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136323#comment-15136323 ]
Evans Ye edited comment on BIGTOP-2012 at 2/7/16 5:09 PM:
----------------------------------------------------------
I figured out why the CommonFunctions is missing. It is because of BIGTOP-2233. For that reason I think all the scripts.lookForGivenString in this patch should be updated to use grep instead.
The following are my comments for the patch:
* The WEBHDFSURL has been hard-coded to 14000 port.
{code}
WEBHDFSURL = "http://$https_host:14000/webhdfs/v1";
{code}
I actually prefer the previous implementation and add doc to tell user to export WEBHDFSURL variable.
* *testCreateFile* failed because the returned http message is in capital, hence the following won't work:
{code}
String OUTMSG = "HTTP/1.1 307 Temporary Redirect";
{code}
I need to change it to
{code}
String OUTMSG = "HTTP/1.1 307 TEMPORARY_REDIRECT";
{code}
I'm not quite sure whether it's environment specific, hence it's better to grep the result in case insensitive way.
* In testGetHomeDir, The home directory doesn't need to have back-slash
{code}
String OUTMSG = "\\/user\\/"+USERNAME+"";
{code}
* Some test depends on previous test. For instance, testRename assume webtest_2.txt already exist. It should create webtest_2.txt by itself and remove it at the end of testRename test.
was (Author: evans_ye):
I figured out why the CommonFunctions is missing. It is because of BIGTOP-2233. For that reason I think all the scripts.lookForGivenString in this patch should be updated to use grep instead.
The following are my comments for the patch:
* The WEBHDFSURL has been hard-coded to 14000 port.
{code}
WEBHDFSURL = "http://$https_host:14000/webhdfs/v1";
{code}
I actually prefer the previous implementation and add doc to tell user to export WEBHDFSURL variable.
* *testCreateFile* failed because the returned http message is in capital:
{code}
String OUTMSG = "HTTP/1.1 307 Temporary Redirect";
{code}
I need to change it to
{code}
String OUTMSG = "HTTP/1.1 307 TEMPORARY_REDIRECT";
{code}
I'm not quite sure whether it's environment specific, hence it's better to grep the result in case insensitive way.
* In testGetHomeDir, The home directory doesn't need to have back-slash
{code}
String OUTMSG = "\\/user\\/"+USERNAME+"";
{code}
* Some test depends on previous test. For instance, testRename assume webtest_2.txt already exist. It should create webtest_2.txt by it self and remove it at the end of testRename test.
> Add new tests for webhdfs
> -------------------------
>
> Key: BIGTOP-2012
> URL: https://issues.apache.org/jira/browse/BIGTOP-2012
> Project: Bigtop
> Issue Type: Sub-task
> Components: general
> Affects Versions: 1.0.0
> Reporter: Venkata Srinivasa Rao Kolla
> Assignee: Venkata Srinivasa Rao Kolla
> Priority: Minor
> Fix For: backlog
>
> Attachments: BIGTOP-2012.patch, BIGTOP-2012.patch, BIGTOP-2012.patch, BIGTOP-2012.patch, BIGTOP-2012.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)