You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Lars Kotthoff (JIRA)" <ji...@apache.org> on 2008/06/06 08:34:44 UTC
[jira] Created: (SOLR-592) Handler components should use parameter
constants instead of hardcoded strings
Handler components should use parameter constants instead of hardcoded strings
------------------------------------------------------------------------------
Key: SOLR-592
URL: https://issues.apache.org/jira/browse/SOLR-592
Project: Solr
Issue Type: Task
Components: search
Affects Versions: 1.3
Reporter: Lars Kotthoff
Priority: Minor
Some classes in o.a.s.handler.component, namely QueryComponent, FacetComponent, and SearchHandler, use hardcoded strings to get/set parameters instead of using the constants defined in CommonParams.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-592) Handler components should use parameter
constants instead of hardcoded strings
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Otis Gospodnetic resolved SOLR-592.
-----------------------------------
Resolution: Fixed
Thank you Lars!
Sending CHANGES.txt
Adding src/java/org/apache/solr/common/params/ShardParams.java
Sending src/java/org/apache/solr/handler/component/FacetComponent.java
Sending src/java/org/apache/solr/handler/component/QueryComponent.java
Sending src/java/org/apache/solr/handler/component/SearchHandler.java
Transmitting file data .....
Committed revision 667923.
> Handler components should use parameter constants instead of hardcoded strings
> ------------------------------------------------------------------------------
>
> Key: SOLR-592
> URL: https://issues.apache.org/jira/browse/SOLR-592
> Project: Solr
> Issue Type: Task
> Components: search
> Affects Versions: 1.3
> Reporter: Lars Kotthoff
> Assignee: Otis Gospodnetic
> Priority: Minor
> Attachments: SOLR-592-parameter-constants.patch
>
>
> Some classes in o.a.s.handler.component, namely QueryComponent, FacetComponent, and SearchHandler, use hardcoded strings to get/set parameters instead of using the constants defined in CommonParams.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-592) Handler components should use parameter
constants instead of hardcoded strings
Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Kotthoff updated SOLR-592:
-------------------------------
Attachment: SOLR-592-parameter-constants.patch
Patch replacing the hardcoded strings with the proper constants. Also introduces o.a.s.common.params.ShardParams which holds the distributed search related parameter constants.
> Handler components should use parameter constants instead of hardcoded strings
> ------------------------------------------------------------------------------
>
> Key: SOLR-592
> URL: https://issues.apache.org/jira/browse/SOLR-592
> Project: Solr
> Issue Type: Task
> Components: search
> Affects Versions: 1.3
> Reporter: Lars Kotthoff
> Priority: Minor
> Attachments: SOLR-592-parameter-constants.patch
>
>
> Some classes in o.a.s.handler.component, namely QueryComponent, FacetComponent, and SearchHandler, use hardcoded strings to get/set parameters instead of using the constants defined in CommonParams.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SOLR-592) Handler components should use parameter
constants instead of hardcoded strings
Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Kotthoff closed SOLR-592.
------------------------------
> Handler components should use parameter constants instead of hardcoded strings
> ------------------------------------------------------------------------------
>
> Key: SOLR-592
> URL: https://issues.apache.org/jira/browse/SOLR-592
> Project: Solr
> Issue Type: Task
> Components: search
> Affects Versions: 1.3
> Reporter: Lars Kotthoff
> Assignee: Otis Gospodnetic
> Priority: Minor
> Attachments: SOLR-592-parameter-constants.patch
>
>
> Some classes in o.a.s.handler.component, namely QueryComponent, FacetComponent, and SearchHandler, use hardcoded strings to get/set parameters instead of using the constants defined in CommonParams.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SOLR-592) Handler components should use parameter
constants instead of hardcoded strings
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Otis Gospodnetic reassigned SOLR-592:
-------------------------------------
Assignee: Otis Gospodnetic
> Handler components should use parameter constants instead of hardcoded strings
> ------------------------------------------------------------------------------
>
> Key: SOLR-592
> URL: https://issues.apache.org/jira/browse/SOLR-592
> Project: Solr
> Issue Type: Task
> Components: search
> Affects Versions: 1.3
> Reporter: Lars Kotthoff
> Assignee: Otis Gospodnetic
> Priority: Minor
> Attachments: SOLR-592-parameter-constants.patch
>
>
> Some classes in o.a.s.handler.component, namely QueryComponent, FacetComponent, and SearchHandler, use hardcoded strings to get/set parameters instead of using the constants defined in CommonParams.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.