You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@brooklyn.apache.org by al...@apache.org on 2016/04/05 19:19:06 UTC
brooklyn-server git commit: pass brooklynConfig when making call to
getLocationSpec - was failing for byon locations where the host wasn't
specified in the type, see associated tests
Repository: brooklyn-server
Updated Branches:
refs/heads/0.9.0 d031cea08 -> 5f2c3c69a
pass brooklynConfig when making call to getLocationSpec
- was failing for byon locations where the host wasn't specified in the type, see associated tests
Project: http://git-wip-us.apache.org/repos/asf/brooklyn-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-server/commit/5f2c3c69
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-server/tree/5f2c3c69
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-server/diff/5f2c3c69
Branch: refs/heads/0.9.0
Commit: 5f2c3c69a5b65c2e314a6d9362680aee8f57a2d5
Parents: d031cea
Author: John McCabe <jo...@johnmccabe.net>
Authored: Tue Apr 5 16:40:51 2016 +0100
Committer: Aled Sage <al...@gmail.com>
Committed: Tue Apr 5 18:18:32 2016 +0100
----------------------------------------------------------------------
.../spi/creation/CampInternalUtils.java | 2 +-
.../catalog/CatalogYamlLocationTest.java | 46 ++++++++++++++++++++
2 files changed, 47 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/brooklyn-server/blob/5f2c3c69/camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/CampInternalUtils.java
----------------------------------------------------------------------
diff --git a/camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/CampInternalUtils.java b/camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/CampInternalUtils.java
index 677c3eb..c2c6c40 100644
--- a/camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/CampInternalUtils.java
+++ b/camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/CampInternalUtils.java
@@ -228,7 +228,7 @@ class CampInternalUtils {
}
return spec;
} else {
- Maybe<LocationSpec<? extends Location>> loc = loader.getManagementContext().getLocationRegistry().getLocationSpec(type);
+ Maybe<LocationSpec<? extends Location>> loc = loader.getManagementContext().getLocationRegistry().getLocationSpec(type, brooklynConfig);
if (loc.isPresent()) {
return loc.get().configure(brooklynConfig);
} else {
http://git-wip-us.apache.org/repos/asf/brooklyn-server/blob/5f2c3c69/camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/CatalogYamlLocationTest.java
----------------------------------------------------------------------
diff --git a/camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/CatalogYamlLocationTest.java b/camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/CatalogYamlLocationTest.java
index dda13ea..9dd9118 100644
--- a/camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/CatalogYamlLocationTest.java
+++ b/camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/CatalogYamlLocationTest.java
@@ -314,4 +314,50 @@ public class CatalogYamlLocationTest extends AbstractYamlTest {
assertLocationManagerInstancesCount(0);
}
+ @Test
+ public void testByonLocationHostsInConfig() {
+ String symbolicName = "my.catalog.app.id.byon.config";
+ addCatalogItems(
+ "brooklyn.catalog:",
+ " version: " + TEST_VERSION,
+ " items:",
+ " - id: " + symbolicName,
+ " itemType: location",
+ " item:",
+ " type: byon",
+ " brooklyn.config:",
+ " displayName: testingdisplayName",
+ " user: testinguser",
+ " password: testingpassword",
+ " hosts:",
+ " - 10.10.10.102"
+ );
+
+ assertLocationRegistryCount(1);
+ assertCatalogCount(1);
+ assertLocationManagerInstancesCount(0);
+ }
+
+ @Test
+ public void testByonLocationHostsInType() {
+ String symbolicName = "my.catalog.app.id.byon.config.inline";
+ addCatalogItems(
+ "brooklyn.catalog:",
+ " version: " + TEST_VERSION,
+ " items:",
+ " - id: " + symbolicName,
+ " itemType: location",
+ " item:",
+ " type: byon:(hosts=\"10.10.10.102\")",
+ " brooklyn.config:",
+ " displayName: testingdisplayName",
+ " user: testinguser",
+ " password: testingpassword"
+ );
+
+ assertLocationRegistryCount(1);
+ assertCatalogCount(1);
+ assertLocationManagerInstancesCount(0);
+ }
+
}