[jira] [Commented] (HBASE-14449) Rewrite deadlock prevention due to concurrent connection close

["Stephen Yuan Jiang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14875891#comment-14875891 ] 

Stephen Yuan Jiang commented on HBASE-14449:
--------------------------------------------

+1 - comparing to the solution in HBASE-14241, this is much simpler and it should solve the concurrent deadlock problem.

> Rewrite deadlock prevention due to concurrent connection close
> --------------------------------------------------------------
>
>                 Key: HBASE-14449
>                 URL: https://issues.apache.org/jira/browse/HBASE-14449
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 14449-v1.txt
>
>
> The deadlock prevention approach used in HBASE-14241 introduces unnecessary logic which is not intuitive.
> Depending on the value for config hbase.ipc.client.specificThreadForWriting , there may or may not be CallSender threads running.
> The attached patch simplifies deadlock prevention by using a Set which represents the Connections to be closed. Outside the synchronized (connections) block, this Set is iterated where the Connections are closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)